Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2955543002: Extensions: Remove duplicate IPC enums in chrome_extension_messages.h. (Closed)

Created:
3 years, 6 months ago by karandeepb
Modified:
3 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, catmullings, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Extensions: Remove duplicate IPC enums in chrome_extension_messages.h. This CL removes duplicate webstore::InstallStage and webstore_install::Result IPC enums from chrome_extension_messages.h. Removing these caused a linker error since IPC::ParamTraits specialization for these were not being generated. Fix this by generating them as part of common_message_generator. BUG=725275 Review-Url: https://codereview.chromium.org/2955543002 Cr-Commit-Position: refs/heads/master@{#482359} Committed: https://chromium.googlesource.com/chromium/src/+/66cb6fb8aeec881dc6b99d6ed3eb1414508f7f53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/common/common_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/chrome_extension_messages.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/common/extensions/mojom/inline_install_traits.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
karandeepb
PTAL Ken.
3 years, 6 months ago (2017-06-23 18:21:11 UTC) #6
karandeepb
+cc catmullings@.
3 years, 6 months ago (2017-06-23 18:21:48 UTC) #7
karandeepb
Ping Ken. +dcheng@ for IPC security review.
3 years, 6 months ago (2017-06-24 02:33:34 UTC) #9
Ken Rockot(use gerrit already)
lgtm
3 years, 6 months ago (2017-06-24 03:05:12 UTC) #10
dcheng
ipc lgtm
3 years, 6 months ago (2017-06-24 03:27:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955543002/1
3 years, 6 months ago (2017-06-24 03:28:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/473051)
3 years, 6 months ago (2017-06-24 03:35:18 UTC) #15
karandeepb
+sky@ for chrome/common/common_message_generator.h review.
3 years, 6 months ago (2017-06-24 03:41:58 UTC) #17
sky
LGTM
3 years, 5 months ago (2017-06-26 15:42:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955543002/1
3 years, 5 months ago (2017-06-26 18:34:17 UTC) #20
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 19:41:48 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66cb6fb8aeec881dc6b99d6ed3eb...

Powered by Google App Engine
This is Rietveld 408576698