Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2955533002: Do not disable ReaderMode when TalkBack is on (Closed)

Created:
3 years, 6 months ago by wychen
Modified:
3 years, 4 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not disable ReaderMode when TalkBack is on ReaderMode became accessible again after https://codereview.chromium.org/2878543003. Therefore, it should not be disabled when TalkBack is turned on anymore. BUG=736168 Review-Url: https://codereview.chromium.org/2955533002 Cr-Commit-Position: refs/heads/master@{#489806} Committed: https://chromium.googlesource.com/chromium/src/+/6c29838bdd576446894d4fa5a7f19974a8c1b51e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
wychen
It's WIP since it crashes. It would be nice if you could take a look ...
3 years, 6 months ago (2017-06-23 01:34:51 UTC) #3
wychen
On 2017/06/23 01:34:51, wychen wrote: > It's WIP since it crashes. It would be nice ...
3 years, 4 months ago (2017-07-26 01:33:23 UTC) #4
mdjones
lgtm
3 years, 4 months ago (2017-07-26 15:56:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955533002/1
3 years, 4 months ago (2017-07-26 21:47:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/348342)
3 years, 4 months ago (2017-07-26 22:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955533002/1
3 years, 4 months ago (2017-07-26 23:20:05 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 00:09:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c29838bdd576446894d4fa5a7f1...

Powered by Google App Engine
This is Rietveld 408576698