Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

Issue 2955503002: Make interstitial links open in a new tab (Closed)
Patch Set: Mock out help center URL in SafeBrowsingBlockingPageTest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/security_interstitials/core/controller_client.h ('K') | « ios/chrome/browser/interstitials/ios_chrome_controller_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
diff --git a/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm b/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
index 1df9dc058b2954d5f79926220a43d6cdcb13d771..4720446506d533a5ce43c5b60398e3ffbf62c506 100644
--- a/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
+++ b/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
@@ -63,6 +63,12 @@ void IOSChromeControllerClient::Reload() {
true /*check_for_repost*/);
}
+void IOSChromeControllerClient::OpenUrlInNewForegroundTab(const GURL& url) {
+ web_state_->OpenURL(web::WebState::OpenURLParams(
+ url, web::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_LINK, false));
+}
+
void IOSChromeControllerClient::OpenUrlInCurrentTab(const GURL& url) {
web_state_->OpenURL(web::WebState::OpenURLParams(
url, web::Referrer(), WindowOpenDisposition::CURRENT_TAB,
« components/security_interstitials/core/controller_client.h ('K') | « ios/chrome/browser/interstitials/ios_chrome_controller_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698