Make interstitial links open in a new tab

components/security_interstitials/core/controller_client.h

Index: components/security_interstitials/core/controller_client.h
diff --git a/components/security_interstitials/core/controller_client.h b/components/security_interstitials/core/controller_client.h
index 613c6bc9f7f6c53cf0c9911e66ae3f6ae4df361f..cfcc8b4b653914b153c40c05ff2ca62bde5ab96b 100644
--- a/components/security_interstitials/core/controller_client.h
+++ b/components/security_interstitials/core/controller_client.h
@@ -9,8 +9,8 @@
 #include <string>
 
 #include "base/macros.h"
+#include "url/gurl.h"
 
-class GURL;
 class PrefService;
 
 namespace security_interstitials {
@@ -87,17 +87,25 @@ class ControllerClient {
 
   MetricsHelper* metrics_helper() const;
 
+  virtual void OpenUrlInNewForegroundTab(const GURL& url) = 0;
+
   virtual void OpenUrlInCurrentTab(const GURL& url) = 0;

[estark, 2017/06/27 00:36:22]

Is this still used anywhere? Can we get rid of it?

[sperigo, 2017/06/27 17:31:59]

I don't think so! I left it in in case there was a use case I was unfamiliar
with. Should I remove it?

 
   virtual PrefService* GetPrefService() = 0;
 
   virtual const std::string& GetApplicationLocale() const = 0;
 
+  GURL GetBaseHelpCenterUrl() const;
+
+  void SetBaseHelpCenterUrlForTesting(const GURL& test_url);
+
  protected:
   virtual const std::string GetExtendedReportingPrefName() const = 0;
 
  private:
   std::unique_ptr<MetricsHelper> metrics_helper_;
+  // Link to the help center.
+  GURL help_center_url_;
 
   DISALLOW_COPY_AND_ASSIGN(ControllerClient);
 };