Make interstitial links open in a new tab

components/security_interstitials/core/controller_client.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SECURITY_INTERSTITIALS_CORE_CONTROLLER_CLIENT_H_
 #define COMPONENTS_SECURITY_INTERSTITIALS_CORE_CONTROLLER_CLIENT_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
+#include "url/gurl.h"
 
-class GURL;
 class PrefService;
 
 namespace security_interstitials {
 
 class MetricsHelper;
 
 // Constants used to communicate with the JavaScript.
 extern const char kBoxChecked[];
 extern const char kDisplayCheckBox[];
 extern const char kOptInLink[];
@@ skipping 56 matching lines @@
   virtual void GoBackAfterNavigationCommitted() = 0;
 
   // Close the error and proceed to the blocked page.
   virtual void Proceed() = 0;
 
   // Reload the blocked page to see if it succeeds now.
   virtual void Reload() = 0;
 
   MetricsHelper* metrics_helper() const;
 
+  virtual void OpenUrlInNewForegroundTab(const GURL& url) = 0;
+
   virtual void OpenUrlInCurrentTab(const GURL& url) = 0;

[estark, 2017/06/27 00:36:22]

Is this still used anywhere? Can we get rid of it?

[sperigo, 2017/06/27 17:31:59]

I don't think so! I left it in in case there was a use case I was unfamiliar
with. Should I remove it?

 
   virtual PrefService* GetPrefService() = 0;
 
   virtual const std::string& GetApplicationLocale() const = 0;
 
+  GURL GetBaseHelpCenterUrl() const;
+
+  void SetBaseHelpCenterUrlForTesting(const GURL& test_url);
+
  protected:
   virtual const std::string GetExtendedReportingPrefName() const = 0;
 
  private:
   std::unique_ptr<MetricsHelper> metrics_helper_;
+  // Link to the help center.
+  GURL help_center_url_;
 
   DISALLOW_COPY_AND_ASSIGN(ControllerClient);
 };
 
 }  // namespace security_interstitials
 
 #endif  // COMPONENTS_SECURITY_INTERSTITIALS_CORE_CONTROLLER_CLIENT_H_