components/security_interstitials/content/security_interstitial_controller_client.h - Issue 2955503002: Make interstitial links open in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/content/security_interstitial_controller_client.h

Issue 2955503002: Make interstitial links open in a new tab (Closed)

Patch Set: Mock out help center URL in SafeBrowsingBlockingPageTest Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/ssl_browser_tests.cc ('K') | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | components/security_interstitials/content/security_interstitial_controller_client.cc » ('j') | components/security_interstitials/core/controller_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/content/security_interstitial_controller_client.h

diff --git a/components/security_interstitials/content/security_interstitial_controller_client.h b/components/security_interstitials/content/security_interstitial_controller_client.h

index f10d26b08c49d738ad9d6f429c247b11104d7608..3237ed776efcef69225324937071f2adaf2df193 100644

--- a/components/security_interstitials/content/security_interstitial_controller_client.h

+++ b/components/security_interstitials/content/security_interstitial_controller_client.h

@@ -44,6 +44,7 @@ class SecurityInterstitialControllerClient

void GoBackAfterNavigationCommitted() override;

void Proceed() override;

void Reload() override;

+ void OpenUrlInNewForegroundTab(const GURL& url) override;

void OpenUrlInCurrentTab(const GURL& url) override;

PrefService* GetPrefService() override;

const std::string& GetApplicationLocale() const override;