Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2955433002: [ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_controller to ARC. (Closed)

Created:
3 years, 6 months ago by gambard
Modified:
3 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_controller to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2955433002 Cr-Commit-Position: refs/heads/master@{#482227} Committed: https://chromium.googlesource.com/chromium/src/+/c11a00b5337c21b6e2e05b6772e14d9bb41124cb

Patch Set 1 #

Patch Set 2 : Remove header #

Patch Set 3 : Rebase #

Patch Set 4 : Fix unittests #

Patch Set 5 : Fix eg tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -112 lines) Patch
M ios/chrome/browser/ui/ntp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.h View 1 2 3 4 4 chunks +21 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.mm View 1 2 3 4 12 chunks +83 lines, -65 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm View 1 2 3 1 chunk +0 lines, -25 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
gambard
PTAL.
3 years, 6 months ago (2017-06-22 13:59:59 UTC) #2
justincohen
lgtm
3 years, 6 months ago (2017-06-22 14:10:29 UTC) #3
gambard
I have updated the tests. PTAL.
3 years, 6 months ago (2017-06-23 14:18:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955433002/80001
3 years, 5 months ago (2017-06-26 09:08:08 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/415066)
3 years, 5 months ago (2017-06-26 09:40:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955433002/80001
3 years, 5 months ago (2017-06-26 09:42:54 UTC) #23
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 10:24:18 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c11a00b5337c21b6e2e05b6772e1...

Powered by Google App Engine
This is Rietveld 408576698