[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2955363002
Cr-Commit-Position: refs/heads/master@{#484007}
Committed: https://chromium.googlesource.com/chromium/src/+/7f53b846dd221596595d909bc57e693e6e68d722

[stkhapugin, 2017-06-28 13:40:20]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 13:40:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-06-28 17:21:38]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 17:21:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 18:48:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:48:46]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-06-29 11:32:41]

stkhapugin@chromium.org changed reviewers:
+ marq@chromium.org

[stkhapugin, 2017-06-29 11:32:42]

PTAL!

[marq (ping after 24h), 2017-06-29 11:57:15]

LGTM, both optional nits.

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/google_landing_mediator.mm (right):

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/google_landing_mediator.mm:133: @property(weak,
nonatomic) id<GoogleLandingConsumer> consumer;
nit: nonatomic, weak

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/incognito_panel_controller.mm (right):

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/incognito_panel_controller.mm:347: - (UIView*)view {
Replace this with a @synthesize? Or is view not a property?

[stkhapugin, 2017-06-29 15:04:50]

Thanks!

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/google_landing_mediator.mm (right):

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/google_landing_mediator.mm:133: @property(weak,
nonatomic) id<GoogleLandingConsumer> consumer;
On 2017/06/29 11:57:15, marq (ping after 24h) wrote:
> nit: nonatomic, weak

Done.

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/incognito_panel_controller.mm (right):

https://codereview.chromium.org/2955363002/diff/40001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/incognito_panel_controller.mm:347: - (UIView*)view {
On 2017/06/29 11:57:15, marq (ping after 24h) wrote:
> Replace this with a @synthesize? Or is view not a property?

Done.

[stkhapugin, 2017-06-29 15:05:00]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-06-29 15:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2955363002/#ps60001
(title: "comments")

[commit-bot: I haz the power, 2017-06-29 15:05:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 16:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 16:27:34]

Failed to apply patch for ios/chrome/browser/ui/ntp/google_landing_mediator.mm:
While running git apply --index -3 -p1;
  error: patch failed: ios/chrome/browser/ui/ntp/google_landing_mediator.mm:128
  Falling back to three-way merge...
  Applied patch to 'ios/chrome/browser/ui/ntp/google_landing_mediator.mm' with
conflicts.
  U ios/chrome/browser/ui/ntp/google_landing_mediator.mm

Patch:       ios/chrome/browser/ui/ntp/google_landing_mediator.mm
Index: ios/chrome/browser/ui/ntp/google_landing_mediator.mm
diff --git a/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
b/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
index
ef06b35d8ba9ad36fdb36734646a180dd9197e99..7bf177be4b0e4c360949d6b5f63c7019a47cfaed
100644
--- a/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
+++ b/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
@@ -4,9 +4,7 @@
 
 #import "ios/chrome/browser/ui/ntp/google_landing_mediator.h"
 
-#import "base/ios/weak_nsobject.h"
 #include "base/mac/bind_objc_block.h"
-#include "base/mac/scoped_nsobject.h"
 #include "base/metrics/user_metrics.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/strings/sys_string_conversions.h"
@@ -44,6 +42,10 @@
 #include "ios/web/public/web_state/web_state.h"
 #include "skia/ext/skia_utils_ios.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 using base::UserMetricsAction;
 
 namespace {
@@ -70,7 +72,7 @@ class SearchEngineObserver : public TemplateURLServiceObserver
{
   void OnTemplateURLServiceChanged() override;
 
  private:
-  base::WeakNSObject<GoogleLandingMediator> _owner;
+  __weak GoogleLandingMediator* _owner;
   TemplateURLService* _templateURLService;  // weak
 };
 
@@ -100,7 +102,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
   BOOL _recordedPageImpression;
 
   // Controller to fetch and show doodles or a default Google logo.
-  base::scoped_nsprotocol<id<LogoVendor>> _doodleController;
+  id<LogoVendor> _doodleController;
 
   // Listen for default search engine changes.
   std::unique_ptr<google_landing::SearchEngineObserver> _observer;
@@ -128,13 +130,13 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
 }
 
 // Consumer to handle google landing update notifications.
-@property(nonatomic) id<GoogleLandingConsumer> consumer;
+@property(nonatomic, weak) id<GoogleLandingConsumer> consumer;
 
 // The WebStateList that is being observed by this mediator.
 @property(nonatomic, assign) WebStateList* webStateList;
 
 // The dispatcher for this mediator.
-@property(nonatomic, assign) id<ChromeExecuteCommand, UrlLoader> dispatcher;
+@property(nonatomic, weak) id<ChromeExecuteCommand, UrlLoader> dispatcher;
 
 // Most visited data from the MostVisitedSites service (copied upon receiving
 // the callback), not yet used.
@@ -200,8 +202,8 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
   _observer.reset(
       new google_landing::SearchEngineObserver(self, _templateURLService));
   _templateURLService->Load();
-  _doodleController.reset(ios::GetChromeBrowserProvider()->CreateLogoVendor(
-      _browserState, self.dispatcher));
+  _doodleController = ios::GetChromeBrowserProvider()->CreateLogoVendor(
+      _browserState, self.dispatcher);
   [_consumer setLogoVendor:_doodleController];
   [self updateShowLogo];
 
@@ -296,7 +298,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
         fallbackCallback:(void (^)(UIColor* textColor,
                                    UIColor* backgroundColor,
                                    BOOL isDefaultColor))fallbackCallback {
-  base::WeakNSObject<GoogleLandingMediator> weakSelf(self);
+  __weak GoogleLandingMediator* weakSelf = self;
 
   void (^faviconBlock)(const favicon_base::LargeIconResult&) = ^(
       const favicon_base::LargeIconResult& result) {
@@ -317,7 +319,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
       fallbackCallback(textColor, backgroundColor, isDefaultColor);
     }
 
-    base::scoped_nsobject<GoogleLandingMediator> strongSelf([weakSelf retain]);
+    GoogleLandingMediator* strongSelf = weakSelf;
     if (strongSelf &&
         (result.bitmap.is_valid() || result.fallback_icon_style)) {
       [strongSelf largeIconCache]->SetCachedResult(URL, result);
@@ -335,7 +337,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
   CGFloat faviconSize = [UIScreen mainScreen].scale * size;
   CGFloat faviconMinSize = [UIScreen mainScreen].scale * kFaviconMinSize;
   [self largeIconService]->GetLargeIconOrFallbackStyle(
-      URL, faviconMinSize, faviconSize, base::BindBlock(faviconBlock),
+      URL, faviconMinSize, faviconSize, base::BindBlockArc(faviconBlock),
       &_cancelable_task_tracker);
 }
 
@@ -430,9 +432,8 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
   }
 
   if (_notification_promo->IsChromeCommand()) {
-    base::scoped_nsobject<GenericChromeCommand> command(
-        [[GenericChromeCommand alloc]
-            initWithTag:_notification_promo->command_id()]);
+    GenericChromeCommand* command = [[GenericChromeCommand alloc]
+        initWithTag:_notification_promo->command_id()];
     [self.dispatcher chromeExecuteCommand:command];
     return;
   }

[stkhapugin, 2017-07-03 14:23:06]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-07-03 14:23:06]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2955363002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-07-03 14:23:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 15:37:04]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499091786151560,
"parent_rev": "56398249f62df4942576ebbaec482d6fd8cea9a7", "commit_rev":
"7f53b846dd221596595d909bc57e693e6e68d722"}

[commit-bot: I haz the power, 2017-07-03 15:37:18]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2955363002
Cr-Commit-Position: refs/heads/master@{#484007}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f53b846dd221596595d909bc57e...
==========

[commit-bot: I haz the power, 2017-07-03 15:37:20]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7f53b846dd221596595d909bc57e...