Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart

Issue 2955353002: Split inference type-info accessors into members, parameters and local functions (Closed)
Patch Set: Cleanup Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart
diff --git a/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart b/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart
index a74a58d08f9a2f9cd5a2ca5ce910192707c5c270..0b0001891ede4a31d3cf549653c7566250f07328 100644
--- a/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart
+++ b/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart
@@ -94,6 +94,12 @@ main() {
enum ResultKind { crashes, errors, warnings, success, failure }
+const List<String> commonOptions = const <String>[
+ Flags.disableTypeInference,
+ Flags.disableInlining,
+ Flags.enableAssertMessage
+];
+
Future<ResultKind> runTest(
Uri entryPoint, Map<String, String> memorySourceFiles,
{bool skipWarnings: false,
@@ -118,11 +124,7 @@ Future<ResultKind> runTest(
entryPoint: entryPoint,
diagnosticHandler: collector,
outputProvider: collector1,
- options: [
- Flags.disableTypeInference,
- Flags.disableInlining,
- Flags.enableAssertMessage
- ]..addAll(options));
+ options: <String>[]..addAll(commonOptions)..addAll(options));
ElementResolutionWorldBuilder.useInstantiationMap = true;
compiler1.resolution.retainCachesForTesting = true;
await compiler1.run(entryPoint);
@@ -144,15 +146,8 @@ Future<ResultKind> runTest(
OutputCollector collector2 = new OutputCollector();
Compiler compiler2 = await compileWithDill(
- entryPoint,
- const {},
- [
- Flags.disableTypeInference,
- Flags.disableInlining,
- Flags.enableAssertMessage
- ]..addAll(options),
- printSteps: true,
- compilerOutput: collector2);
+ entryPoint, const {}, <String>[]..addAll(commonOptions)..addAll(options),
+ printSteps: true, compilerOutput: collector2);
KernelFrontEndStrategy frontendStrategy = compiler2.frontendStrategy;
KernelToElementMap elementMap = frontendStrategy.elementMap;

Powered by Google App Engine
This is Rietveld 408576698