Split inference type-info accessors into members, parameters and local functions

tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Helper to test compilation equivalence between source and .dill based
 // compilation.
 library dart2js.kernel.compile_from_dill_test_helper;
 
 import 'dart:async';
 import 'dart:io';
@@ skipping 76 matching lines @@
   }
   x = toplevel;
   print(x);
   return x;
 }
 '''
 };
 
 enum ResultKind { crashes, errors, warnings, success, failure }
 
+const List<String> commonOptions = const <String>[
+  Flags.disableTypeInference,
+  Flags.disableInlining,
+  Flags.enableAssertMessage
+];
+
 Future<ResultKind> runTest(
     Uri entryPoint, Map<String, String> memorySourceFiles,
     {bool skipWarnings: false,
     bool skipErrors: false,
     bool verbose: false,
     List<String> options: const <String>[]}) async {
   enableDebugMode();
   EnumCreator.matchKernelRepresentationForTesting = true;
   Elements.usePatchedDart2jsSdkSorting = true;
 
   Directory dir = await Directory.systemTemp.createTemp('dart2js-with-dill');
   print('--- create temp directory $dir -------------------------------');
   memorySourceFiles.forEach((String name, String source) {
     new File.fromUri(dir.uri.resolve(name)).writeAsStringSync(source);
   });
   entryPoint = dir.uri.resolve(entryPoint.path);
 
   print('---- compile from ast ----------------------------------------------');
   DiagnosticCollector collector = new DiagnosticCollector();
   OutputCollector collector1 = new OutputCollector();
   Compiler compiler1 = compilerFor(
       entryPoint: entryPoint,
       diagnosticHandler: collector,
       outputProvider: collector1,
-      options: [
-        Flags.disableTypeInference,
-        Flags.disableInlining,
-        Flags.enableAssertMessage
-      ]..addAll(options));
+      options: <String>[]..addAll(commonOptions)..addAll(options));
   ElementResolutionWorldBuilder.useInstantiationMap = true;
   compiler1.resolution.retainCachesForTesting = true;
   await compiler1.run(entryPoint);
   if (collector.crashes.isNotEmpty) {
     print('Skipping due to crashes.');
     return ResultKind.crashes;
   }
   if (collector.errors.isNotEmpty && skipErrors) {
     print('Skipping due to errors.');
     return ResultKind.errors;
   }
   if (collector.warnings.isNotEmpty && skipWarnings) {
     print('Skipping due to warnings.');
     return ResultKind.warnings;
   }
   Expect.isFalse(compiler1.compilationFailed);
   ClosedWorld closedWorld1 =
       compiler1.resolutionWorldBuilder.closedWorldForTesting;
 
   OutputCollector collector2 = new OutputCollector();
   Compiler compiler2 = await compileWithDill(
-      entryPoint,
-      const {},
-      [
-        Flags.disableTypeInference,
-        Flags.disableInlining,
-        Flags.enableAssertMessage
-      ]..addAll(options),
-      printSteps: true,
-      compilerOutput: collector2);
+      entryPoint, const {}, <String>[]..addAll(commonOptions)..addAll(options),
+      printSteps: true, compilerOutput: collector2);
 
   KernelFrontEndStrategy frontendStrategy = compiler2.frontendStrategy;
   KernelToElementMap elementMap = frontendStrategy.elementMap;
 
   Expect.isFalse(compiler2.compilationFailed);
 
   KernelEquivalence equivalence = new KernelEquivalence(elementMap);
 
   ClosedWorld closedWorld2 =
       compiler2.resolutionWorldBuilder.closedWorldForTesting;
@@ skipping 48 matching lines @@
     }
     Map<String, BufferedOutputSink> map2 = collector2.outputMap[outputType];
     checkSets(map1.keys, map2.keys, 'output', equality);
     map1.forEach((String name, BufferedOutputSink output1) {
       BufferedOutputSink output2 = map2[name];
       Expect.stringEquals(output1.text, output2.text);
     });
   });
   return ResultKind.success;
 }