Split inference type-info accessors into members, parameters and local functions

Split inference type-info accessors into members, parameters and local functions

This prepares for using LocalFunctionElement.callMethod as the key for local
functions instead of the local functions themselves - corresponding to the world
after closure conversion.

Main changes in
  elements/elements.dart
  inferrer/inferrer_engine.dart
  inferrer/type_graph_inferrer.dart
  inferrer/type_system.dart

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/34290dca77f252e88199012e1346b70cc2162003

[Johnni Winther, 2017-06-28 12:00:52]

Description was changed from

==========
Split inference type-info accessors into members, parameters and local functions

This prepares for using LocalFunctionElement.callMethod as the key for local
functions instead of the local functions themselves - corresponding to the world
after closure conversion.
==========

to

==========
Split inference type-info accessors into members, parameters and local functions

This prepares for using LocalFunctionElement.callMethod as the key for local 
functions instead of the local functions themselves - corresponding to the world
after closure conversion.

Main changes in 
  elements/elements.dart
  inferrer/inferrer_engine.dart
  inferrer/type_graph_inferrer.dart
  inferrer/type_system.dart
==========

[Johnni Winther, 2017-06-28 12:01:03]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-28 16:30:24]

lgtm

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/builder.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/builder.dart:1055: if (analyzedElement.isLocal) {
to avoid duplicating this if-else in these four cases, could we just call
recordReturnType like we do further below?

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/node_tracer.dart:222: }
nit: maybe use this style to avoid duplicating the body of the branches:

TypeInformation inferred = called.isLocal
  ? inferrer.types.getInferredTypeOfLocalFunction(called)
  : inferrer.types.getInferredTypeOfMember(called)

if (inferred == currentUser) addNewEscapeInformation(info);

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:81: if (element is!
FunctionElement) return _dynamicType;
should we require the parameter to be a MethodElement instead and delete this
check here?

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/ty...
File pkg/compiler/lib/src/types/types.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/types/types.dart:263: @deprecated
might be worth commenting what is this going to be replaced with.

For instance: we are moving away from using LocalFunctionElement to represent
closures, but plan to use the <closure-class>.callMethod instead as the
representation. At that point, we should be able to sue
getReturnTypeOfMember(callMethod). (I guess?)

Might be worth also sprinkling hints about this in the other @deprecated
annotations in the other files.

[Johnni Winther, 2017-06-29 12:36:49]

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/builder.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/builder.dart:1055: if (analyzedElement.isLocal) {
On 2017/06/28 16:30:24, Siggi Cherem (dart-lang) wrote:
> to avoid duplicating this if-else in these four cases, could we just call
> recordReturnType like we do further below?

Done.

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/node_tracer.dart:222: }
On 2017/06/28 16:30:24, Siggi Cherem (dart-lang) wrote:
> nit: maybe use this style to avoid duplicating the body of the branches:
> 
> TypeInformation inferred = called.isLocal
>   ? inferrer.types.getInferredTypeOfLocalFunction(called)
>   : inferrer.types.getInferredTypeOfMember(called)
> 
> if (inferred == currentUser) addNewEscapeInformation(info);

Done.

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:81: if (element is!
FunctionElement) return _dynamicType;
On 2017/06/28 16:30:24, Siggi Cherem (dart-lang) wrote:
> should we require the parameter to be a MethodElement instead and delete this
> check here?

Done.

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/ty...
File pkg/compiler/lib/src/types/types.dart (right):

https://codereview.chromium.org/2955353002/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/types/types.dart:263: @deprecated
On 2017/06/28 16:30:24, Siggi Cherem (dart-lang) wrote:
> might be worth commenting what is this going to be replaced with.
> 
> For instance: we are moving away from using LocalFunctionElement to represent
> closures, but plan to use the <closure-class>.callMethod instead as the
> representation. At that point, we should be able to sue
> getReturnTypeOfMember(callMethod). (I guess?)
> 
> Might be worth also sprinkling hints about this in the other @deprecated
> annotations in the other files. 

Done.

[Johnni Winther, 2017-06-29 12:46:54]

Description was changed from

==========
Split inference type-info accessors into members, parameters and local functions

This prepares for using LocalFunctionElement.callMethod as the key for local 
functions instead of the local functions themselves - corresponding to the world
after closure conversion.

Main changes in 
  elements/elements.dart
  inferrer/inferrer_engine.dart
  inferrer/type_graph_inferrer.dart
  inferrer/type_system.dart
==========

to

==========
Split inference type-info accessors into members, parameters and local functions

This prepares for using LocalFunctionElement.callMethod as the key for local
functions instead of the local functions themselves - corresponding to the world
after closure conversion.

Main changes in
  elements/elements.dart
  inferrer/inferrer_engine.dart
  inferrer/type_graph_inferrer.dart
  inferrer/type_system.dart

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/34290dca77f252e88199012e1346b70cc2162003
==========

[Johnni Winther, 2017-06-29 12:46:56]

Committed patchset #3 (id:40001) manually as
34290dca77f252e88199012e1346b70cc2162003 (presubmit successful).