Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2955303002: Bounding boxes in the accessibility tree should always be relative to a box. (Closed)

Created:
3 years, 5 months ago by dmazzoni
Modified:
3 years, 5 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, haraken, nektarios, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, je_julie, dmazzoni, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Bounding boxes in the accessibility tree should always be relative to a box. The accessibility tree stores bounding boxes relative to the nearest container, which allows for efficient handling of transformations in the layout tree. Previously we were allowing any box model object to be a container, but this resulted in incorrect results for the static text child of an inline element with position:relative. Fix this by requiring containers to be boxes. BUG=737130 Review-Url: https://codereview.chromium.org/2955303002 Cr-Commit-Position: refs/heads/master@{#483823} Committed: https://chromium.googlesource.com/chromium/src/+/f3c32d8c2da3969d676bc6255224d779bda01ed2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/css/inline-position-relative.html View 1 chunk +26 lines, -0 lines 0 comments Download
A content/test/data/accessibility/css/inline-position-relative-expected-blink.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/bounds-calc.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
dmazzoni
3 years, 5 months ago (2017-06-28 19:11:59 UTC) #6
aboxhall
lgtm
3 years, 5 months ago (2017-06-30 06:09:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955303002/1
3 years, 5 months ago (2017-06-30 19:07:40 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 21:22:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f3c32d8c2da3969d676bc6255224...

Powered by Google App Engine
This is Rietveld 408576698