Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: Source/bindings/v8/V8PerIsolateData.h

Issue 29553002: Move privateTemplateUniqueKey / sharedTemplateUniqueKey to .bss section (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update sharedTemplateUniqueKey as well Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8PerIsolateData.h
diff --git a/Source/bindings/v8/V8PerIsolateData.h b/Source/bindings/v8/V8PerIsolateData.h
index 00c43d6dc77109a3b7f640663bf7d1bae26bfd20..07ca302ae2e615f03c485403788e0373bc762c40 100644
--- a/Source/bindings/v8/V8PerIsolateData.h
+++ b/Source/bindings/v8/V8PerIsolateData.h
@@ -63,7 +63,7 @@ public:
}
static void dispose(v8::Isolate*);
- typedef HashMap<void*, UnsafePersistent<v8::FunctionTemplate> > TemplateMap;
+ typedef HashMap<const void*, UnsafePersistent<v8::FunctionTemplate> > TemplateMap;
TemplateMap& rawTemplateMap(WrapperWorldType worldType)
{
@@ -129,9 +129,9 @@ public:
void clearShouldCollectGarbageSoon() { m_shouldCollectGarbageSoon = false; }
bool shouldCollectGarbageSoon() const { return m_shouldCollectGarbageSoon; }
- v8::Handle<v8::FunctionTemplate> privateTemplate(WrapperWorldType, void* privatePointer, v8::FunctionCallback = 0, v8::Handle<v8::Value> data = v8::Handle<v8::Value>(), v8::Handle<v8::Signature> = v8::Handle<v8::Signature>(), int length = 0);
- v8::Handle<v8::FunctionTemplate> privateTemplateIfExists(WrapperWorldType, void* privatePointer);
- void setPrivateTemplate(WrapperWorldType, void* privatePointer, v8::Handle<v8::FunctionTemplate>);
+ v8::Handle<v8::FunctionTemplate> privateTemplate(WrapperWorldType, const void* privatePointer, v8::FunctionCallback = 0, v8::Handle<v8::Value> data = v8::Handle<v8::Value>(), v8::Handle<v8::Signature> = v8::Handle<v8::Signature>(), int length = 0);
+ v8::Handle<v8::FunctionTemplate> privateTemplateIfExists(WrapperWorldType, const void* privatePointer);
+ void setPrivateTemplate(WrapperWorldType, const void* privatePointer, v8::Handle<v8::FunctionTemplate>);
v8::Handle<v8::FunctionTemplate> rawTemplate(WrapperTypeInfo*, WrapperWorldType);

Powered by Google App Engine
This is Rietveld 408576698