Source/bindings/v8/V8DOMWrapper.cpp - Issue 29553002: Move privateTemplateUniqueKey / sharedTemplateUniqueKey to .bss section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8DOMWrapper.cpp

Issue 29553002: Move privateTemplateUniqueKey / sharedTemplateUniqueKey to .bss section (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update sharedTemplateUniqueKey as well Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8DOMWrapper.cpp

diff --git a/Source/bindings/v8/V8DOMWrapper.cpp b/Source/bindings/v8/V8DOMWrapper.cpp

index 29354fb67c510d5a53a5adced840877770be9e15..0b15c718cddac85b80bf57d50e7b24db36ea76f6 100644

--- a/Source/bindings/v8/V8DOMWrapper.cpp

+++ b/Source/bindings/v8/V8DOMWrapper.cpp

@@ -80,7 +80,7 @@ private:

static v8::Local<v8::Object> wrapInShadowTemplate(v8::Local<v8::Object> wrapper, Node* impl, v8::Isolate* isolate)

{

// This is only for getting a unique pointer which we can pass to privateTemplate.

- static const char* shadowTemplateUniqueKey = "wrapInShadowTemplate";

+ static const int shadowTemplateUniqueKey = 0;

WrapperWorldType currentWorldType = worldType(isolate);

V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> shadowTemplate = data->privateTemplateIfExists(currentWorldType, &shadowTemplateUniqueKey);