Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: milo/buildsource/buildbot/pubsub_test.go

Issue 2955223002: Milo: Buildbucket PubSub ingestion outline (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/buildsource/buildbot/pubsub.go ('k') | milo/buildsource/buildbucket/builder_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/buildbot/pubsub_test.go
diff --git a/milo/buildsource/buildbot/pubsub_test.go b/milo/buildsource/buildbot/pubsub_test.go
index cfa24bf5421f865676ba08d1e1726dfa778b8436..02076ec4fd5ea8b9c31dc5c0978421b8652320c7 100644
--- a/milo/buildsource/buildbot/pubsub_test.go
+++ b/milo/buildsource/buildbot/pubsub_test.go
@@ -71,9 +71,9 @@ func newCombinedPsBody(bs []*buildbotBuild, m *buildbotMaster, internal bool) io
if internal {
sub = "projects/luci-milo/subscriptions/buildbot-private"
}
- msg := pubSubSubscription{
+ msg := common.PubSubSubscription{
Subscription: sub,
- Message: pubSubMessage{
+ Message: common.PubSubMessage{
Data: base64.StdEncoding.EncodeToString(b.Bytes()),
},
}
@@ -92,7 +92,7 @@ func TestPubSub(t *testing.T) {
IdentityGroups: []string{"all"},
})
// Update the service config so that the settings are loaded.
- err := common.UpdateServiceConfig(c)
+ _, err := common.UpdateServiceConfig(c)
So(err, ShouldBeNil)
rand.Seed(5)
« no previous file with comments | « milo/buildsource/buildbot/pubsub.go ('k') | milo/buildsource/buildbucket/builder_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698