Milo: Buildbucket PubSub ingestion outline

milo/buildsource/buildbot/pubsub_test.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "bytes"
         "compress/zlib"
         "encoding/base64"
@@ skipping 53 matching lines @@
         }
         bm, _ := json.Marshal(bmsg)
         var b bytes.Buffer
         zw := zlib.NewWriter(&b)
         zw.Write(bm)
         zw.Close()
         sub := "projects/luci-milo/subscriptions/buildbot-public"
         if internal {
                 sub = "projects/luci-milo/subscriptions/buildbot-private"
         }
-        msg := pubSubSubscription{
+        msg := common.PubSubSubscription{
                 Subscription: sub,
-                Message: pubSubMessage{
+                Message: common.PubSubMessage{
                         Data: base64.StdEncoding.EncodeToString(b.Bytes()),
                 },
         }
         jmsg, _ := json.Marshal(msg)
         return ioutil.NopCloser(bytes.NewReader(jmsg))
 }
 
 func TestPubSub(t *testing.T) {
         Convey(`A test Environment`, t, func() {
                 c := memory.UseWithAppID(context.Background(), "dev~luci-milo")
                 c = gologger.StdConfig.Use(c)
                 c, _ = testclock.UseTime(c, fakeTime)
                 c = testconfig.WithCommonClient(c, memcfg.New(bbAclConfigs))
                 c = auth.WithState(c, &authtest.FakeState{
                         Identity:       identity.AnonymousIdentity,
                         IdentityGroups: []string{"all"},
                 })
                 // Update the service config so that the settings are loaded.
-                err := common.UpdateServiceConfig(c)
+                _, err := common.UpdateServiceConfig(c)
                 So(err, ShouldBeNil)
 
                 rand.Seed(5)
 
                 Convey("Remove source changes", func() {
                         m := &buildbotMaster{
                                 Name: "fake",
                                 Builders: map[string]*buildbotBuilder{
                                         "fake builder": {
                                                 PendingBuildStates: []*buildbotPending{
@@ skipping 379 matching lines @@
                                 So(m.Project.Title, ShouldEqual, "some title")
                                 So(m.Slaves["testslave"].Name, ShouldEqual, "testslave")
                                 So(len(m.Slaves["testslave"].Runningbuilds), ShouldEqual, 0)
                                 So(len(m.Slaves["testslave"].RunningbuildsMap), ShouldEqual, 1)
                                 So(m.Slaves["testslave"].RunningbuildsMap["Fake buildername"][0],
                                         ShouldEqual, 2222)
                         })
                 })
         })
 }