Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 295513003: add 'slow' prefix to RenderObject's firstChild() / lastChild() methods (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
Reviewers:
pdr., esprehn
CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, blink-layers+watch_chromium.org, caseq+blink_chromium.org, krit, aboxhall, malch+blink_chromium.org, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, rune+blink, mstensho+blink_opera.com, loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, Stephen Chennney, blink-reviews-rendering, kouhei+svg_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, dmazzoni, f(malita), sergeyv+blink_chromium.org
Visibility:
Public.

Description

add 'slow' prefix to RenderObject's firstChild() / lastChild() methods add 'slow' prefix to RenderObject's firstChild() / lastChild() methods to make it obvious to callers that calling these method on a RenderObject is expensive and tighter typing should be used when possible. This CL takes care of using getting rid of easily avoidable calls to slowFirstChild() / slowLastChild(). R=esprehn@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -145 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 6 chunks +13 lines, -11 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Position.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/PluginOcclusionSupport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/FixedTableLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineIterator.h View 8 chunks +8 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 8 chunks +21 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 11 chunks +14 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 6 chunks +9 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 21 chunks +23 lines, -23 lines 0 comments Download
M Source/core/rendering/RenderRuby.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderTable.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTableSection.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/TextAutosizer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/TextAutosizer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGResourcesCycleSolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 7 months ago (2014-05-19 01:08:13 UTC) #1
pdr.
On 2014/05/19 01:08:13, Chris Dumez wrote: LGTM, nice
6 years, 7 months ago (2014-05-19 02:59:22 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-05-19 12:17:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/295513003/1
6 years, 7 months ago (2014-05-19 12:17:43 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 12:32:55 UTC) #5
Message was sent while issue was closed. 
Change committed as 174275

Powered by Google App Engine
This is Rietveld 408576698