Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2955103003: Implement _ChildNodeListLazy.removeRange as throwing UnsupportedError (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement _ChildNodeListLazy.removeRange as throwing UnsupportedError _ChildNodeListLazy.removeRange used to throw UnsupportedError because ListMixin.removeRange calls setRange. Make throwing UnsupportedError explicit to avoid relying on the implementation of ListMixin.removeRange This will unblock the '_closeGap' change. BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/fc7d880c60e8b553e0006141f8b670dba5a1f4bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 5 months ago (2017-06-28 00:40:53 UTC) #4
Lasse Reichstein Nielsen
lgtm
3 years, 5 months ago (2017-06-28 05:30:52 UTC) #5
sra1
3 years, 5 months ago (2017-06-28 16:43:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc7d880c60e8b553e0006141f8b670dba5a1f4bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698