Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: tools/dom/templates/html/impl/impl_Node.darttemplate

Issue 2955103003: Implement _ChildNodeListLazy.removeRange as throwing UnsupportedError (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of $LIBRARYNAME; 5 part of $LIBRARYNAME;
6 6
7 /** 7 /**
8 * Lazy implementation of the child nodes of an element that does not request 8 * Lazy implementation of the child nodes of an element that does not request
9 * the actual child nodes of an element until strictly necessary greatly 9 * the actual child nodes of an element until strictly necessary greatly
10 * improving performance for the typical cases where it is not required. 10 * improving performance for the typical cases where it is not required.
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 170
171 // FIXME: implement these. 171 // FIXME: implement these.
172 void setRange(int start, int end, Iterable<Node> iterable, 172 void setRange(int start, int end, Iterable<Node> iterable,
173 [int skipCount = 0]) { 173 [int skipCount = 0]) {
174 throw new UnsupportedError("Cannot setRange on Node list"); 174 throw new UnsupportedError("Cannot setRange on Node list");
175 } 175 }
176 176
177 void fillRange(int start, int end, [Node fill]) { 177 void fillRange(int start, int end, [Node fill]) {
178 throw new UnsupportedError("Cannot fillRange on Node list"); 178 throw new UnsupportedError("Cannot fillRange on Node list");
179 } 179 }
180
181 void removeRange(int start, int end) {
182 throw new UnsupportedError("Cannot removeRange on Node list");
183 }
180 // -- end List<Node> mixins. 184 // -- end List<Node> mixins.
181 185
182 // TODO(jacobr): benchmark whether this is more efficient or whether caching 186 // TODO(jacobr): benchmark whether this is more efficient or whether caching
183 // a local copy of childNodes is more efficient. 187 // a local copy of childNodes is more efficient.
184 int get length => _this.childNodes.length; 188 int get length => _this.childNodes.length;
185 189
186 set length(int value) { 190 set length(int value) {
187 throw new UnsupportedError( 191 throw new UnsupportedError(
188 "Cannot set length on immutable List."); 192 "Cannot set length on immutable List.");
189 } 193 }
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 */ 313 */
310 @DomName('Node.childNodes') 314 @DomName('Node.childNodes')
311 @DocsEditable() 315 @DocsEditable()
312 @Returns('NodeList') 316 @Returns('NodeList')
313 @Creates('NodeList') 317 @Creates('NodeList')
314 final List<Node> childNodes; 318 final List<Node> childNodes;
315 319
316 $endif 320 $endif
317 $!MEMBERS 321 $!MEMBERS
318 } 322 }
OLDNEW
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698