Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2955063002: [ignition] Slightly improve code for Call/Construct bytecodes. (Closed)

Created:
3 years, 5 months ago by Benedikt Meurer
Modified:
3 years, 5 months ago
Reviewers:
mythria, rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Slightly improve code for Call/Construct bytecodes. The Construct bytecode is always passed a valid feedback slot (just like the Call bytecode), so no need to check for invalid feedback slot anymore. Also perform the call count increment initially for both bytecodes instead of delaying it, which decreases live range for the feedback vector and slot registers. R=mythria@chromium.org, rmcilroy@chromium.org BUG=v8:4280 Review-Url: https://codereview.chromium.org/2955063002 Cr-Commit-Position: refs/heads/master@{#46232} Committed: https://chromium.googlesource.com/v8/v8/+/bd185e9998fb3db40fb3e90823669bb94682cd17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M src/interpreter/interpreter-assembler.cc View 6 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 5 months ago (2017-06-27 05:08:55 UTC) #1
Benedikt Meurer
Tiny cleanup/refactoring. Please take a look.
3 years, 5 months ago (2017-06-27 05:09:35 UTC) #4
mythria
lgtm. Thanks, Mythri
3 years, 5 months ago (2017-06-27 07:56:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955063002/1
3 years, 5 months ago (2017-06-27 08:17:52 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 08:19:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bd185e9998fb3db40fb3e90823669bb9468...

Powered by Google App Engine
This is Rietveld 408576698