Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 2955053003: Line-wrap Reader Mode infobar if the text is too long (Closed)
Patch Set: move padding to reader mode Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/values/dimens.xml
diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml
index 8f2718c41d9770d2a0952682f4fefb1a3aca891a..3ca8eab2f2ba9ba295a0163a640deaf463e3c5d9 100644
--- a/chrome/android/java/res/values/dimens.xml
+++ b/chrome/android/java/res/values/dimens.xml
@@ -63,6 +63,8 @@
<!-- Infobar dimensions -->
<!-- Text size of the infobar message and other controls. -->
<dimen name="infobar_text_size">16sp</dimen>
+ <!-- Padding surrounding the message. -->
+ <dimen name="infobar_text_padding">8dp</dimen>
mdjones 2017/06/27 21:54:28 nit: make this reader mode specific too.
wychen 2017/06/27 22:03:35 Good catch!
<!-- Text size of the infobar message when a big icon is shown. -->
<dimen name="infobar_big_icon_message_size">18sp</dimen>
<!-- Text size of descriptive controls on an infobar. -->
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698