Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2955053003: Line-wrap Reader Mode infobar if the text is too long (Closed)
Patch Set: move padding to reader mode Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources> 6 <resources>
7 <!-- Connection info popup dimensions --> 7 <!-- Connection info popup dimensions -->
8 <dimen name="connection_info_padding_wide">24dp</dimen> 8 <dimen name="connection_info_padding_wide">24dp</dimen>
9 <dimen name="connection_info_padding_thin">16dp</dimen> 9 <dimen name="connection_info_padding_thin">16dp</dimen>
10 10
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 via scrolling. --> 56 via scrolling. -->
57 <dimen name="menu_vertical_fade_distance">15dp</dimen> 57 <dimen name="menu_vertical_fade_distance">15dp</dimen>
58 <dimen name="menu_badge_translation_y_distance">6dp</dimen> 58 <dimen name="menu_badge_translation_y_distance">6dp</dimen>
59 59
60 <!-- Menu button dragging related dimensions --> 60 <!-- Menu button dragging related dimensions -->
61 <dimen name="auto_scroll_full_velocity">500dp</dimen> 61 <dimen name="auto_scroll_full_velocity">500dp</dimen>
62 62
63 <!-- Infobar dimensions --> 63 <!-- Infobar dimensions -->
64 <!-- Text size of the infobar message and other controls. --> 64 <!-- Text size of the infobar message and other controls. -->
65 <dimen name="infobar_text_size">16sp</dimen> 65 <dimen name="infobar_text_size">16sp</dimen>
66 <!-- Padding surrounding the message. -->
67 <dimen name="infobar_text_padding">8dp</dimen>
mdjones 2017/06/27 21:54:28 nit: make this reader mode specific too.
wychen 2017/06/27 22:03:35 Good catch!
66 <!-- Text size of the infobar message when a big icon is shown. --> 68 <!-- Text size of the infobar message when a big icon is shown. -->
67 <dimen name="infobar_big_icon_message_size">18sp</dimen> 69 <dimen name="infobar_big_icon_message_size">18sp</dimen>
68 <!-- Text size of descriptive controls on an infobar. --> 70 <!-- Text size of descriptive controls on an infobar. -->
69 <dimen name="infobar_descriptive_text_size">14sp</dimen> 71 <dimen name="infobar_descriptive_text_size">14sp</dimen>
70 <!-- Padding surrounding the infobar. --> 72 <!-- Padding surrounding the infobar. -->
71 <dimen name="infobar_padding">16dp</dimen> 73 <dimen name="infobar_padding">16dp</dimen>
72 <!-- Margin between stacked buttons in an infobar. --> 74 <!-- Margin between stacked buttons in an infobar. -->
73 <dimen name="infobar_margin_between_stacked_buttons">24dp</dimen> 75 <dimen name="infobar_margin_between_stacked_buttons">24dp</dimen>
74 <!-- Minimum width of an infobar. --> 76 <!-- Minimum width of an infobar. -->
75 <dimen name="infobar_min_width">220dp</dimen> 77 <dimen name="infobar_min_width">220dp</dimen>
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 <dimen name="context_menu_header_image_max_size">56dp</dimen> 476 <dimen name="context_menu_header_image_max_size">56dp</dimen>
475 <dimen name="context_menu_max_width">500dp</dimen> 477 <dimen name="context_menu_max_width">500dp</dimen>
476 478
477 <!-- Divider Dimensions --> 479 <!-- Divider Dimensions -->
478 <dimen name="divider_height">1dp</dimen> 480 <dimen name="divider_height">1dp</dimen>
479 481
480 <!-- Search widget dimensions --> 482 <!-- Search widget dimensions -->
481 <dimen name="search_activity_location_bar_margin_start">16dp</dimen> 483 <dimen name="search_activity_location_bar_margin_start">16dp</dimen>
482 <dimen name="search_activity_location_bar_margin_end">8dp</dimen> 484 <dimen name="search_activity_location_bar_margin_end">8dp</dimen>
483 </resources> 485 </resources>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698