Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc

Issue 2955023002: VR: Factor transient timing out of UiSceneManager. (Closed)
Patch Set: Get rid of EndVisibility(). Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
index fc142a2a59446b6d2109390607d45f07893e1d07..55ebf3ba957e2afd09e9d3ff4bbecdb7b4d37350 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
@@ -165,6 +165,8 @@ TEST_F(UiSceneManagerTest, WebVrTransientWarningTimesOut) {
}
TEST_F(UiSceneManagerTest, ToastVisibility) {
+ base::ScopedMockTimeMessageLoopTaskRunner task_runner_;
bshe 2017/06/27 14:57:09 Do you need this? Or do you want to add time sensi
cjgrant 2017/06/28 19:00:55 Done. I made a separate test to verify transience
+
// Tests toast not showing when directly entering VR though WebVR
// presentation.
MakeManager(kNotInCct, kInWebVr);
@@ -189,7 +191,7 @@ TEST_F(UiSceneManagerTest, ToastVisibility) {
EXPECT_FALSE(IsVisible(kPresentationToast));
manager_->SetWebVrMode(false, false, true);
- EXPECT_TRUE(IsVisible(kPresentationToast));
+ EXPECT_FALSE(IsVisible(kPresentationToast));
}
TEST_F(UiSceneManagerTest, CloseButtonVisibleInCctFullscreen) {

Powered by Google App Engine
This is Rietveld 408576698