VR: Factor transient timing out of UiSceneManager.

chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene_manager.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/test/scoped_mock_time_message_loop_task_runner.h"
@@ skipping 147 matching lines @@
   // Note: Fast-forwarding appears broken in conjunction with restarting timers.
   // In this test, we can fast-forward by the appropriate time interval, but in
   // other cases (until the bug is addressed), we could work around the problem
   // by using FastForwardUntilNoTasksRemain() instead.
   // See http://crbug.com/736558.
   task_runner_->FastForwardBy(base::TimeDelta::FromSeconds(31));
   EXPECT_FALSE(IsVisible(kWebVrTransientHttpSecurityWarning));
 }
 
 TEST_F(UiSceneManagerTest, ToastVisibility) {
+  base::ScopedMockTimeMessageLoopTaskRunner task_runner_;

[bshe, 2017/06/27 14:57:09]

Do you need this? Or do you want to add time sensitive test to this unit test
too?

[cjgrant, 2017/06/28 19:00:55]

Done.  I made a separate test to verify transience.

+
   // Tests toast not showing when directly entering VR though WebVR
   // presentation.
   MakeManager(kNotInCct, kInWebVr);
   EXPECT_FALSE(IsVisible(kPresentationToast));
 
   MakeManager(kNotInCct, kNotInWebVr);
   EXPECT_FALSE(IsVisible(kPresentationToast));
 
   manager_->SetFullscreen(true);
   EXPECT_TRUE(IsVisible(kPresentationToast));
 
   manager_->SetWebVrMode(true, false, true);
   EXPECT_TRUE(IsVisible(kPresentationToast));
 
   manager_->SetWebVrMode(false, false, false);
   EXPECT_FALSE(IsVisible(kPresentationToast));
 
   manager_->SetFullscreen(false);
   EXPECT_FALSE(IsVisible(kPresentationToast));
 
   manager_->SetWebVrMode(true, false, false);
   EXPECT_FALSE(IsVisible(kPresentationToast));
 
   manager_->SetWebVrMode(false, false, true);
-  EXPECT_TRUE(IsVisible(kPresentationToast));
+  EXPECT_FALSE(IsVisible(kPresentationToast));
 }
 
 TEST_F(UiSceneManagerTest, CloseButtonVisibleInCctFullscreen) {
   // Button should be visible in cct.
   MakeManager(kInCct, kNotInWebVr);
   EXPECT_TRUE(IsVisible(kCloseButton));
 
   // Button should not be visible when not in cct or fullscreen.
   MakeManager(kNotInCct, kNotInWebVr);
   EXPECT_FALSE(IsVisible(kCloseButton));
@@ skipping 218 matching lines @@
 
   // Ensure they can be turned off.
   manager_->SetAudioCapturingIndicator(false);
   manager_->SetVideoCapturingIndicator(false);
   manager_->SetScreenCapturingIndicator(false);
   manager_->SetLocationAccessIndicator(false);
   EXPECT_TRUE(VerifyVisibility(indicators, false));
 }
 
 }  // namespace vr_shell