Use GPU bots for swarming gl_unittests on "CFI Linux Full".

Use GPU bots for swarming gl_unittests on "CFI Linux Full".

Looks like this is necessary for this test suite to work with
swarming on Linux.

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/2296/steps/gl_unittests
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_cfi_rel_ng/builds/198/steps/gl_unittests%20%28with%20patch%29

BUG=732652
R=dpranke@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2955003002
Cr-Commit-Position: refs/heads/master@{#482404}
Committed: https://chromium.googlesource.com/chromium/src/+/42563f2e4edbcf0589e93d811a41c71b088e4d86

[pcc1, 2017-06-26 18:51:40]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 18:52:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-06-26 19:17:56]

thakis@chromium.org changed reviewers:
+ kbr@chromium.org

[Nico, 2017-06-26 19:17:57]

kbr, was there some special thing needed to run gl_unittests on swarming?

[Ken Russell (switch to Gerrit), 2017-06-26 19:25:36]

On 2017/06/26 19:17:57, Nico (vacation Jun 30-Jul 11) wrote:
> kbr, was there some special thing needed to run gl_unittests on swarming?

They're run on the GPU bots -- see
src/content/test/gpu/generate_buildbot_json.py and the .json files it generates
-- they need physical hardware to run correctly at this point.

[pcc1, 2017-06-26 19:54:34]

On 2017/06/26 19:25:36, Ken Russell (switch to Gerrit) wrote:
> On 2017/06/26 19:17:57, Nico (vacation Jun 30-Jul 11) wrote:
> > kbr, was there some special thing needed to run gl_unittests on swarming?
> 
> They're run on the GPU bots -- see
> src/content/test/gpu/generate_buildbot_json.py and the .json files it
generates
> -- they need physical hardware to run correctly at this point.

I see, I have updated the configuration to match the one that chromium.gpu uses.

[pcc1, 2017-06-26 19:55:36]

Description was changed from

==========
Disable swarming for gl_unittests on "CFI Linux Full".

Looks like gl_unittests is incompatible with swarming on Linux.

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/...
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

BUG=732652
R=dpranke@chromium.org,thakis@chromium.org
==========

to

==========
Use GPU bots for swarming gl_unittests on "CFI Linux Full".

Looks like this is necessary for this test suite to work with
swarming on Linux.

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/...
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

BUG=732652
R=dpranke@chromium.org,thakis@chromium.org
==========

[pcc1, 2017-06-26 19:56:17]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[pcc1, 2017-06-26 19:56:24]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 19:56:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2017-06-26 20:09:03]

lgtm

Note that we maintain most of the GPU tests' entries using the script
src/content/test/gpu/generate_buildbot_json.py . It looks like it would be a lot
of work to subsume the generation of chromium.fyi into that script, but in
general I think we should work toward better declarative descriptions of the
waterfalls, and the tests which run on each bot. (There's a lot of replication
on the GPU bots.)

[Ken Russell (switch to Gerrit), 2017-06-26 20:09:32]

Also: could you update the Subject of the CL description?

[pcc1, 2017-06-26 20:12:05]

The CQ bit was unchecked by pcc@chromium.org

[pcc1, 2017-06-26 20:12:05]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-06-26 20:12:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 21:19:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498507925921310,
"parent_rev": "9beaa97d0c8c4d1ab60cd288f81bb1af77eb5505", "commit_rev":
"42563f2e4edbcf0589e93d811a41c71b088e4d86"}

[commit-bot: I haz the power, 2017-06-26 21:20:11]

Description was changed from

==========
Use GPU bots for swarming gl_unittests on "CFI Linux Full".

Looks like this is necessary for this test suite to work with
swarming on Linux.

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/...
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

BUG=732652
R=dpranke@chromium.org,thakis@chromium.org
==========

to

==========
Use GPU bots for swarming gl_unittests on "CFI Linux Full".

Looks like this is necessary for this test suite to work with
swarming on Linux.

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/...
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

BUG=732652
R=dpranke@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2955003002
Cr-Commit-Position: refs/heads/master@{#482404}
Committed:
https://chromium.googlesource.com/chromium/src/+/42563f2e4edbcf0589e93d811a41...
==========

[commit-bot: I haz the power, 2017-06-26 21:20:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/42563f2e4edbcf0589e93d811a41...