Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2954963003: Request Composition Range Updates for Focused GuestViews based on BrowserPlugins (Closed)

Created:
3 years, 5 months ago by EhsanK
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Request Composition Range Updates for Focused GuestViews based on BrowserPlugins Since the patch https://codereview.chromium.org/2121953002/ landed, composition range information are only requested for RenderWidgets which have a focused text input box, that is, their TextInputState.type != ui::TEXT_INPUT_STATE_NONE. This change however is not implemented for guest views which are based on BrowserPlugin and therefore, some IME features in Japanese IME have regressed for <webview>s. While this is not a bug in OOPIF-based guests, it is still an important bug to fix because: 1- PDFs will still use BrowserPlugin for a while, 2- OOPIF-based <webview>'s might not launch in M60. This patch will add the support by sending the request after BrowserPluginGuest forwards a TextInputStateChanged call to RenderWidgetHostViewGuest. BUG=714771 Review-Url: https://codereview.chromium.org/2929543002 Cr-Original-Commit-Position: refs/heads/master@{#479698} Review-Url: https://codereview.chromium.org/2954963003 . Cr-Commit-Position: refs/branch-heads/3112@{#466} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/48285bdee11f3f1ed3ec16cbdbce5ddbd8681232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -2 lines) Patch
M chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc View 4 chunks +106 lines, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +14 lines, -1 line 0 comments Download
M content/browser/renderer_host/text_input_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/test/text_input_test_utils.h View 2 chunks +17 lines, -0 lines 0 comments Download
M content/public/test/text_input_test_utils.cc View 5 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
EhsanK
3 years, 5 months ago (2017-06-26 18:23:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48285bdee11f3f1ed3ec16cbdbce5ddbd8681232.

Powered by Google App Engine
This is Rietveld 408576698