Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2954823002: Implement type inference for try/catch blocks. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement type inference for try/catch blocks. Note that the types of the exception and stack trace variables are set in the BodyBuilder since they do not depend on inference of other parts of the function. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7553b2e75c4272e6f7eb5a89f4efcf79dc3ad389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/accessors.dart.direct.expect View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/expressions.dart.direct.expect View 2 chunks +2 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch.dart.direct.expect View 1 chunk +40 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch.dart.outline.expect View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch.dart.strong.expect View 1 chunk +40 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_finally.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_finally.dart.direct.expect View 1 chunk +44 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_finally.dart.outline.expect View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_finally.dart.strong.expect View 1 chunk +44 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_promotion.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_promotion.dart.direct.expect View 1 chunk +35 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_promotion.dart.outline.expect View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_catch_promotion.dart.strong.expect View 1 chunk +35 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_finally.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_finally.dart.direct.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_finally.dart.outline.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/try_finally.dart.strong.expect View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/kompile.status View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/kernel/lib/core_types.dart View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
Peter to review kernel changes Anyone to review front_end changes This is not urgent; feel ...
3 years, 6 months ago (2017-06-24 22:02:57 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-26 15:05:23 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-26 15:57:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7553b2e75c4272e6f7eb5a89f4efcf79dc3ad389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698