Refactor PDFiumPage::GetLinkTarget() into smaller methods.

Refactor PDFiumPage::GetLinkTarget() into smaller methods.

Also update TODOs and clean up random nits.

Review-Url: https://codereview.chromium.org/2954813002
Cr-Commit-Position: refs/heads/master@{#482715}
Committed: https://chromium.googlesource.com/chromium/src/+/139fa7485d7b9b407df9e8a7d00e688770e4e117

[Lei Zhang, 2017-06-24 05:20:51]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-24 05:20:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 07:11:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 07:11:23]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Lei Zhang, 2017-06-26 19:33:41]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2017-06-26 19:44:39]

https://codereview.chromium.org/2954813002/diff/1/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/2954813002/diff/1/pdf/pdfium/pdfium_page.cc#n...
pdf/pdfium/pdfium_page.cc:356: if (target) {
if (!target)
  return WEBLINK_AREA;

https://codereview.chromium.org/2954813002/diff/1/pdf/pdfium/pdfium_page.cc#n...
pdf/pdfium/pdfium_page.cc:359: if (buffer_size > 0) {
ditto early exit?

[Lei Zhang, 2017-06-26 20:58:00]

https://codereview.chromium.org/2954813002/diff/1/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/2954813002/diff/1/pdf/pdfium/pdfium_page.cc#n...
pdf/pdfium/pdfium_page.cc:356: if (target) {
On 2017/06/26 19:44:38, dsinclair wrote:
> if (!target)
>   return WEBLINK_AREA;

I wrote it this way because:
- Early returns ends up taking more lines.
- It's more obvious that this only ever returns WEBLINK_AREA given the single
return statement.
- It's short enough of a function and the nesting isn't too deep.

[dsinclair, 2017-06-27 15:19:32]

lgtm

[Lei Zhang, 2017-06-27 18:40:44]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-06-27 18:41:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 19:51:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498588844571920, "parent_rev":
"7d380bea073931bcc05118e861ffe2d8fe0d9403", "commit_rev":
"139fa7485d7b9b407df9e8a7d00e688770e4e117"}

[commit-bot: I haz the power, 2017-06-27 19:51:54]

Description was changed from

==========
Refactor PDFiumPage::GetLinkTarget() into smaller methods.

Also update TODOs and clean up random nits.
==========

to

==========
Refactor PDFiumPage::GetLinkTarget() into smaller methods.

Also update TODOs and clean up random nits.

Review-Url: https://codereview.chromium.org/2954813002
Cr-Commit-Position: refs/heads/master@{#482715}
Committed:
https://chromium.googlesource.com/chromium/src/+/139fa7485d7b9b407df9e8a7d00e...
==========

[commit-bot: I haz the power, 2017-06-27 19:51:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/139fa7485d7b9b407df9e8a7d00e...