Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2954793002: color: Replace more instances of ICCProfile with ColorSpace (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
hubbe
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, dshwang, creis+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, nasko+codewatch_chromium.org, jam, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, blink-reviews-api_chromium.org, krit, dglazkov+blink, Rik, darin-cc_chromium.org, Justin Novosad, mac-reviews_chromium.org, blink-reviews, drott+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Replace more instances of ICCProfile with ColorSpace The gfx::ColorSpace representation is more compact and can communicate information such as HDR status. TBR=hubbe BUG=735613 Review-Url: https://codereview.chromium.org/2954793002 Cr-Commit-Position: refs/heads/master@{#482155} Committed: https://chromium.googlesource.com/chromium/src/+/ab0aab82705d56bc09d6a4fe0a91eb43a610f30e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/screen_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/screen_info.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebScreenInfo.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
ccameron
This covers some of the suggestions you had from the previous patch .. turns out ...
3 years, 6 months ago (2017-06-24 08:09:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954793002/1
3 years, 6 months ago (2017-06-24 08:35:11 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-24 17:22:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab0aab82705d56bc09d6a4fe0a91...

Powered by Google App Engine
This is Rietveld 408576698