Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 2954753002: Add Cronet experimental option for host cache persistence (Closed)

Created:
3 years, 6 months ago by mgersh
Modified:
3 years, 5 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Cronet experimental option for host cache persistence Allows embedders to enable host cache persistence with their choice of delay, and creates a HostCachePersistenceManager when the option is enabled. Includes an integration test. BUG=605149 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2954753002 Cr-Commit-Position: refs/heads/master@{#483024} Committed: https://chromium.googlesource.com/chromium/src/+/ac5f75a1f6948c9ace870d57c3df502e9ed802f5

Patch Set 1 #

Total comments: 20

Patch Set 2 : address comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -9 lines) Patch
M components/cronet/android/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 3 chunks +7 lines, -1 line 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 7 chunks +29 lines, -8 lines 0 comments Download
M components/cronet/android/test/cronet_test_jni.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A components/cronet/android/test/experimental_options_test.h View 1 chunk +16 lines, -0 lines 0 comments Download
A components/cronet/android/test/experimental_options_test.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java View 1 2 chunks +63 lines, -0 lines 2 comments Download
M components/cronet/url_request_context_config.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
mgersh
PTAL. This isn't quite done, I want to add some histograms and logging in this ...
3 years, 6 months ago (2017-06-23 22:10:28 UTC) #3
pauljensen
https://codereview.chromium.org/2954753002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/2954753002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc#newcode118 components/cronet/android/cronet_url_request_context_adapter.cc:118: const char kHostCache[] = "net.host_cache"; Can we add a ...
3 years, 5 months ago (2017-06-26 16:37:18 UTC) #4
mgersh
https://codereview.chromium.org/2954753002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/2954753002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc#newcode118 components/cronet/android/cronet_url_request_context_adapter.cc:118: const char kHostCache[] = "net.host_cache"; On 2017/06/26 16:37:17, pauljensen ...
3 years, 5 months ago (2017-06-26 23:21:45 UTC) #5
pauljensen
https://codereview.chromium.org/2954753002/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java File components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java (right): https://codereview.chromium.org/2954753002/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java#newcode194 components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java:194: callback.blockForDone(); is this racing the load of the host ...
3 years, 5 months ago (2017-06-27 11:27:11 UTC) #6
mgersh
https://codereview.chromium.org/2954753002/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java File components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java (right): https://codereview.chromium.org/2954753002/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java#newcode194 components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java:194: callback.blockForDone(); On 2017/06/27 11:27:11, pauljensen wrote: > is this ...
3 years, 5 months ago (2017-06-27 14:07:20 UTC) #7
mgersh
I said this on the other CL, but mentioning it here too: I changed my ...
3 years, 5 months ago (2017-06-27 14:34:44 UTC) #8
pauljensen
lgtm
3 years, 5 months ago (2017-06-27 18:14:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954753002/20001
3 years, 5 months ago (2017-06-28 14:21:59 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 16:53:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac5f75a1f6948c9ace870d57c3df...

Powered by Google App Engine
This is Rietveld 408576698