Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2954603002: Extend unit test for json/begin_recording endpoint. (Closed)

Created:
3 years, 6 months ago by erikchen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, jam, darin-cc_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend unit test for json/begin_recording endpoint. The end-point now supports passing memory dump configs. Add tests. BUG=chromium:735124 Review-Url: https://codereview.chromium.org/2954603002 Cr-Commit-Position: refs/heads/master@{#481914} Committed: https://chromium.googlesource.com/chromium/src/+/840112713871f67a18d1ee296e42055a40a45be5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M content/browser/tracing/tracing_ui_unittest.cc View 4 chunks +22 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
erikchen
primiano: Please review.
3 years, 6 months ago (2017-06-23 01:02:35 UTC) #3
Primiano Tucci (use gerrit)
LGTM https://codereview.chromium.org/2954603002/diff/1/content/browser/tracing/tracing_ui_unittest.cc File content/browser/tracing/tracing_ui_unittest.cc (right): https://codereview.chromium.org/2954603002/diff/1/content/browser/tracing/tracing_ui_unittest.cc#newcode58 content/browser/tracing/tracing_ui_unittest.cc:58: std::unique_ptr<base::ListValue> triggers(new base::ListValue); /me pretends to not realize ...
3 years, 6 months ago (2017-06-23 09:43:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954603002/1
3 years, 6 months ago (2017-06-23 16:08:35 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 16:13:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/840112713871f67a18d1ee296e42...

Powered by Google App Engine
This is Rietveld 408576698