Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2954553002: Enable some SafeBrowsing browser tests on the network service fyi bot. (Closed)

Created:
3 years, 6 months ago by yzshen1
Modified:
3 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, mikecase+watch_chromium.org, agrieve+watch_chromium.org, darin (slow to review), jbudorick+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable some SafeBrowsing browser tests on the network service fyi bot. BUG=736081 Review-Url: https://codereview.chromium.org/2954553002 Cr-Commit-Position: refs/heads/master@{#484607} Committed: https://chromium.googlesource.com/chromium/src/+/378a9a29ffab72232c5e1d06c8bb70919ba6c35f

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M testing/buildbot/filters/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A testing/buildbot/filters/mojo.fyi.network_browser_tests.filter View 1 2 3 4 5 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 5 months ago (2017-07-05 19:16:13 UTC) #2
jam
lgtm
3 years, 5 months ago (2017-07-06 15:10:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954553002/100001
3 years, 5 months ago (2017-07-06 15:29:04 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 15:35:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/378a9a29ffab72232c5e1d06c8bb...

Powered by Google App Engine
This is Rietveld 408576698