Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2954533002: Mark unused input histograms as obsolete. (Closed)

Created:
3 years, 6 months ago by tdresser
Modified:
3 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark unused input histograms as obsolete. Mark these as obsolete. We'll then wait a bit to see if anyone objects, and if not, we'll remove these. BUG=677873, 677073, 667588 etc. Review-Url: https://codereview.chromium.org/2954533002 Cr-Commit-Position: refs/heads/master@{#482382} Committed: https://chromium.googlesource.com/chromium/src/+/3fa6b8068adfbd44223e0ecf367b75cfed128899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 62 chunks +186 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
tdresser
+metric owners to confirm marking these obsolete is okay, as discussed here: https://groups.google.com/a/chromium.org/forum/#!msg/input-dev/R1ovLVy2a-c/iBig58K3CAAJ;context-place=topicsearchin/input-dev/histogram
3 years, 6 months ago (2017-06-22 19:32:07 UTC) #2
dtapuska
On 2017/06/22 19:32:07, tdresser wrote: > +metric owners to confirm marking these obsolete is okay, ...
3 years, 6 months ago (2017-06-22 19:53:33 UTC) #3
ccameron
also lgtm
3 years, 6 months ago (2017-06-23 19:23:28 UTC) #4
Rick Byers
LGTM (we can always add something back if we end up wanting it in the ...
3 years, 6 months ago (2017-06-23 19:25:50 UTC) #5
tdresser
+isherman@ for histograms.xml review.
3 years, 6 months ago (2017-06-23 19:27:08 UTC) #7
Ilya Sherman
LGTM, thanks.
3 years, 5 months ago (2017-06-26 19:07:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954533002/1
3 years, 5 months ago (2017-06-26 19:12:23 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 20:33:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3fa6b8068adfbd44223e0ecf367b...

Powered by Google App Engine
This is Rietveld 408576698