Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 2954393002: Fix test failure on Cronet Asan bot (Closed)

Created:
3 years, 5 months ago by mgersh
Modified:
3 years, 5 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, bengr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix test failure on Cronet Asan bot HostCachePersistenceManager didn't properly initialize writing_pref_, which caused it to miss the initial read from prefs when asan is enabled. BUG=736803 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2954393002 Cr-Commit-Position: refs/heads/master@{#482349} Committed: https://chromium.googlesource.com/chromium/src/+/7d383c8584f0dde579e78f7a47f17fd14b227311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/cronet/host_cache_persistence_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mgersh
3 years, 5 months ago (2017-06-26 18:36:12 UTC) #3
mef
lgtm
3 years, 5 months ago (2017-06-26 18:42:28 UTC) #4
mgersh
3 years, 5 months ago (2017-06-26 18:44:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954393002/1
3 years, 5 months ago (2017-06-26 18:44:30 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 19:20:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d383c8584f0dde579e78f7a47f1...

Powered by Google App Engine
This is Rietveld 408576698