Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2954373002: Make the control buttons on a notification always show on non Chrome OS platform. (Closed)

Created:
3 years, 5 months ago by Peter Beverloo
Modified:
3 years, 5 months ago
Reviewers:
yoshiki, yhanada
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, Peter Beverloo, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Make the control buttons on a notification always show on non Chrome OS platform. BUG=726812 TEST=Checks that the close button is always shown on Linux and it is shown only when the mouse hovers on Chrome OS. NOTRY=true NOPRESUBMIT=true Change-Id: I42aaefe989780f9740bd4a7061ddd41cb0b8f64c Reviewed-on: https://chromium-review.googlesource.com/530726 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>; Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#478886} Review-Url: https://codereview.chromium.org/2954373002 Cr-Commit-Position: refs/branch-heads/3112@{#475} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/afbceb46878cee15b862ed364670c01336deb73a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Peter Beverloo
+yoshiki, yhanada: PTAL I had to do a manual merge since arc_custom_notification_view.cc got renamed since ...
3 years, 5 months ago (2017-06-26 17:53:40 UTC) #2
yoshiki
lgtm
3 years, 5 months ago (2017-06-27 01:36:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954373002/1
3 years, 5 months ago (2017-06-27 02:20:06 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 5 months ago (2017-06-27 02:20:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954373002/1
3 years, 5 months ago (2017-06-27 02:25:09 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 02:25:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/afbceb46878cee15b862ed364670...

Powered by Google App Engine
This is Rietveld 408576698