[DevTools] Migrate inspector-protocol/layers tests to new harness

[DevTools] Migrate inspector-protocol/layers tests to new harness

BUG=734762
Review-Url: https://codereview.chromium.org/2954343004
Cr-Commit-Position: refs/heads/master@{#483182}
Committed: https://chromium.googlesource.com/chromium/src/+/e3d688d2a057ff181778d873b3adbb9b48fae106

[dgozman, 2017-06-27 22:43:52]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-06-27 22:43:52]

Could you please take a look?

[dgozman, 2017-06-27 23:59:57]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 00:00:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 00:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 00:03:09]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[caseq, 2017-06-28 17:19:53]

lgtm

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js
(right):

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js:13:
function attributesFromArray(attributes) {
Let's drop it.

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js:47:
response = await dp.DOM.getAttributes({nodeId: response.result.nodeIds[0]});
Let's not reuse vairables. This could be

var nodeId = (await ...).result.nodeIds[0];
var attributes = (await ...).result.attributes;

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js:48: var
attributes = attributesFromArray(response.result.attributes);
var attributesMap = new Map(response.result.attributes);

[dgozman, 2017-06-28 19:58:22]

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js
(right):

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js:13:
function attributesFromArray(attributes) {
On 2017/06/28 17:19:53, caseq wrote:
> Let's drop it.

Done.

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js:47:
response = await dp.DOM.getAttributes({nodeId: response.result.nodeIds[0]});
On 2017/06/28 17:19:53, caseq wrote:
> Let's not reuse vairables. This could be
> 
> var nodeId = (await ...).result.nodeIds[0];
> var attributes = (await ...).result.attributes;

Done.

https://codereview.chromium.org/2954343004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/layers/get-layers.js:48: var
attributes = attributesFromArray(response.result.attributes);
On 2017/06/28 17:19:53, caseq wrote:
> var attributesMap = new Map(response.result.attributes);

Done.

[dgozman, 2017-06-28 19:58:49]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-28 19:58:49]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2954343004/#ps20001
(title: "rebased, addressed comments")

[commit-bot: I haz the power, 2017-06-28 19:59:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 21:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 21:19:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2017-06-28 21:31:41]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-28 21:31:42]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2954343004/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2017-06-28 21:32:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 23:01:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498685501869750,
"parent_rev": "d4c0b80def96186ea0662090ea9c54f22ee5c4cd", "commit_rev":
"e3d688d2a057ff181778d873b3adbb9b48fae106"}

[commit-bot: I haz the power, 2017-06-28 23:01:32]

Description was changed from

==========
[DevTools] Migrate inspector-protocol/layers tests to new harness

BUG=734762
==========

to

==========
[DevTools] Migrate inspector-protocol/layers tests to new harness

BUG=734762

Review-Url: https://codereview.chromium.org/2954343004
Cr-Commit-Position: refs/heads/master@{#483182}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3d688d2a057ff181778d873b3ad...
==========

[commit-bot: I haz the power, 2017-06-28 23:01:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e3d688d2a057ff181778d873b3ad...