Source/core/animation/AnimatableShapeValue.h - Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimatableShapeValue.h

Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/AnimatableRepeatable.h ('K') | « Source/core/animation/AnimatableSVGPaint.h ('k') | Source/core/animation/AnimatableStrokeDasharrayList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/AnimatableShapeValue.h

diff --git a/Source/core/animation/AnimatableShapeValue.h b/Source/core/animation/AnimatableShapeValue.h

index f8fcdd6db2a35e46e377c6b519fe72b02d31d27f..696a376d4b97163f469e0e4ee1d4e9bbb6d52396 100644

--- a/Source/core/animation/AnimatableShapeValue.h

+++ b/Source/core/animation/AnimatableShapeValue.h

@@ -59,11 +59,7 @@ private:

RefPtr<ShapeValue> m_shape;

};

-inline const AnimatableShapeValue* toAnimatableShapeValue(const AnimatableValue* value)

- ASSERT_WITH_SECURITY_IMPLICATION(value && value->isShapeValue());

- return static_cast<const AnimatableShapeValue*>(value);

+DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableShapeValue, isShapeValue());

} // namespace WebCore