DCHECK that scheduler tasks have positive duration.

DCHECK that scheduler tasks have positive duration.

We're running into issues with tasks that appear to end before
they start. This patch moves the issue upstream a bit.

BUG=703648
Review-Url: https://codereview.chromium.org/2954283003
Cr-Commit-Position: refs/heads/master@{#483171}
Committed: https://chromium.googlesource.com/chromium/src/+/48ea1273a02f225c876093ff16574b8cf2139eee

[tdresser, 2017-06-26 16:19:39]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 16:19:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 18:03:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 18:03:54]

Dry run: This issue passed the CQ dry run.

[tdresser, 2017-06-26 18:06:34]

tdresser@chromium.org changed reviewers:
+ skyostil@chromium.org

[tdresser, 2017-06-26 18:06:40]

PTAL

[tdresser, 2017-06-28 17:34:16]

Ping.

[Sami, 2017-06-28 17:42:48]

lgtm -- sorry, too many review tools to keep track of :)

https://codereview.chromium.org/2954283003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2954283003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1913:
DCHECK(start_time <= end_time);
nit: Consider using DCHECK_LE to get a nicer error message.

[tdresser, 2017-06-28 17:55:02]

https://codereview.chromium.org/2954283003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2954283003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1913:
DCHECK(start_time <= end_time);
On 2017/06/28 17:42:48, Sami wrote:
> nit: Consider using DCHECK_LE to get a nicer error message.

Done.

[tdresser, 2017-06-28 17:55:06]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2017-06-28 17:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2954283003/#ps20001
(title: "DCHECK_LE")

[commit-bot: I haz the power, 2017-06-28 17:55:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 22:23:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498672506094210,
"parent_rev": "5b58af3409b37c9f12ee12c94c947aca1e8598dd", "commit_rev":
"48ea1273a02f225c876093ff16574b8cf2139eee"}

[commit-bot: I haz the power, 2017-06-28 22:24:08]

Description was changed from

==========
DCHECK that scheduler tasks have positive duration.

We're running into issues with tasks that appear to end before
they start. This patch moves the issue upstream a bit.

BUG=703648
==========

to

==========
DCHECK that scheduler tasks have positive duration.

We're running into issues with tasks that appear to end before
they start. This patch moves the issue upstream a bit.

BUG=703648

Review-Url: https://codereview.chromium.org/2954283003
Cr-Commit-Position: refs/heads/master@{#483171}
Committed:
https://chromium.googlesource.com/chromium/src/+/48ea1273a02f225c876093ff1657...
==========

[commit-bot: I haz the power, 2017-06-28 22:24:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48ea1273a02f225c876093ff1657...