Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2954283003: DCHECK that scheduler tasks have positive duration. (Closed)

Created:
3 years, 5 months ago by tdresser
Modified:
3 years, 5 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DCHECK that scheduler tasks have positive duration. We're running into issues with tasks that appear to end before they start. This patch moves the issue upstream a bit. BUG=703648 Review-Url: https://codereview.chromium.org/2954283003 Cr-Commit-Position: refs/heads/master@{#483171} Committed: https://chromium.googlesource.com/chromium/src/+/48ea1273a02f225c876093ff16574b8cf2139eee

Patch Set 1 #

Total comments: 2

Patch Set 2 : DCHECK_LE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tdresser
PTAL
3 years, 5 months ago (2017-06-26 18:06:40 UTC) #6
tdresser
Ping.
3 years, 5 months ago (2017-06-28 17:34:16 UTC) #7
Sami
lgtm -- sorry, too many review tools to keep track of :) https://codereview.chromium.org/2954283003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc ...
3 years, 5 months ago (2017-06-28 17:42:48 UTC) #8
tdresser
https://codereview.chromium.org/2954283003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc (right): https://codereview.chromium.org/2954283003/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc#newcode1913 third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:1913: DCHECK(start_time <= end_time); On 2017/06/28 17:42:48, Sami wrote: > ...
3 years, 5 months ago (2017-06-28 17:55:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954283003/20001
3 years, 5 months ago (2017-06-28 17:55:35 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 22:24:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48ea1273a02f225c876093ff1657...

Powered by Google App Engine
This is Rietveld 408576698