Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2954223002: Revert of Add the Play Store app search to the launcher. (Closed)

Created:
3 years, 6 months ago by dcheng
Modified:
3 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, darin (slow to review), qsr+mojo_chromium.org, tablet-launcher_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the Play Store app search to the launcher. (patchset #17 id:300001 of https://codereview.chromium.org/2929273002/ ) Reason for revert: Linux ChromiumOS Builder (dbg) is failing compile: ../../chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc:0: error: undefined reference to 'app_list::kIcBadgeInstantIcon' ../../chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc:0: error: undefined reference to 'app_list::kIcBadgePlayIcon' Original issue's description: > Add the Play Store app search to the launcher. > > Bug=736552 > > Review-Url: https://codereview.chromium.org/2929273002 > Cr-Commit-Position: refs/heads/master@{#482130} > Committed: https://chromium.googlesource.com/chromium/src/+/fa1bfdf6d5fb0952a524f4ca048ff104fdbdb2dd TBR=lhchavez@chromium.org,xiyuan@chromium.org,hejq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug=736552 Review-Url: https://codereview.chromium.org/2954223002 Cr-Commit-Position: refs/heads/master@{#482136} Committed: https://chromium.googlesource.com/chromium/src/+/1fef8cf8bc356c704eb27eee979c45895e6f4d69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -635 lines) Patch
M chrome/browser/ui/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/app_context_menu.h View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/app_list/arc/arc_playstore_app_context_menu.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/app_list/arc/arc_playstore_app_context_menu.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M chrome/browser/ui/app_list/search/arc_app_result.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M components/arc/common/app.mojom View 4 chunks +3 lines, -21 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/arc/test/fake_app_instance.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/app_list/vector_icons/ic_badge_instant.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/app_list/vector_icons/ic_badge_instant.1x.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/app_list/vector_icons/ic_badge_play.icon View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/app_list/vector_icons/ic_badge_play.1x.icon View 1 chunk +0 lines, -37 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_view.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dcheng
Created Revert of Add the Play Store app search to the launcher.
3 years, 6 months ago (2017-06-24 03:53:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954223002/1
3 years, 6 months ago (2017-06-24 03:53:47 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-24 03:54:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1fef8cf8bc356c704eb27eee979c...

Powered by Google App Engine
This is Rietveld 408576698