Issue 2954203002: Ensure default dialog button focus remains after a dialog update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2954203002: Ensure default dialog button focus remains after a dialog update. (Closed)

Created:
3 years, 6 months ago by Devlin

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Ensure default dialog button focus remains after a dialog update. BUG=709346 Review-Url: https://codereview.chromium.org/2807653002 Cr-Original-Commit-Position: refs/heads/master@{#475165} Review-Url: https://codereview.chromium.org/2954203002 . Cr-Commit-Position: refs/branch-heads/3112@{#453} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2c003ddd2dfa6f0605ba5a3f949e3558f7f15447

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -3 lines)			Patch
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/window/dialog_client_view.cc	View	4 chunks	+41 lines, -0 lines	0 comments	Download
M	ui/views/window/dialog_client_view_unittest.cc	View	2 chunks	+29 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Devlin

3 years, 6 months ago (2017-06-23 21:16:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2c003ddd2dfa6f0605ba5a3f949e3558f7f15447.