Attempt to prevent screenshot failures from preventing original failure stack.

Attempt to prevent screenshot failures from preventing original failure stack.

Saw an exception like this on the bots:
java.lang.RuntimeException: Error while connecting UiAutomation
	at android.app.UiAutomation.connect(UiAutomation.java:203)
	at android.app.Instrumentation.getUiAutomation(Instrumentation.java:1680)
	at android.support.test.uiautomator.j.<init>(UiDevice.java:90)
	at android.support.test.uiautomator.j.a(UiDevice.java:249)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:1055)
	at android.support.test.internal.a.b.run(UiThreadStatement.java:44)
	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1719)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)

Which prevented me from seeing the original failure.

BUG=736380
Review-Url: https://codereview.chromium.org/2954183002
Cr-Commit-Position: refs/heads/master@{#482004}
Committed: https://chromium.googlesource.com/chromium/src/+/27a522ddf6ece1cccf741e309e035bf0d461657a

[Ted C, 2017-06-23 19:06:19]

tedchoc@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Ted C, 2017-06-23 19:06:19]

PTAL

[Ted C, 2017-06-23 19:06:41]

On 2017/06/23 19:06:19, Ted C wrote:
> PTAL

Failing build:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/4...

[jbudorick, 2017-06-23 19:11:27]

lgtm

+mikecase fyi

[Ted C, 2017-06-23 19:22:16]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-06-23 19:22:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 20:22:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498245736181160, "parent_rev":
"bf0dae2525be222e524a7fcb8e6e370165ea1441", "commit_rev":
"27a522ddf6ece1cccf741e309e035bf0d461657a"}

[commit-bot: I haz the power, 2017-06-23 20:22:42]

Description was changed from

==========
Attempt to prevent screenshot failures from preventing original failure stack.

Saw an exception like this on the bots:
java.lang.RuntimeException: Error while connecting UiAutomation
	at android.app.UiAutomation.connect(UiAutomation.java:203)
	at android.app.Instrumentation.getUiAutomation(Instrumentation.java:1680)
	at android.support.test.uiautomator.j.<init>(UiDevice.java:90)
	at android.support.test.uiautomator.j.a(UiDevice.java:249)
	at
org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:1055)
	at android.support.test.internal.a.b.run(UiThreadStatement.java:44)
	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1719)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)

Which prevented me from seeing the original failure.

BUG=736380
==========

to

==========
Attempt to prevent screenshot failures from preventing original failure stack.

Saw an exception like this on the bots:
java.lang.RuntimeException: Error while connecting UiAutomation
	at android.app.UiAutomation.connect(UiAutomation.java:203)
	at android.app.Instrumentation.getUiAutomation(Instrumentation.java:1680)
	at android.support.test.uiautomator.j.<init>(UiDevice.java:90)
	at android.support.test.uiautomator.j.a(UiDevice.java:249)
	at
org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:1055)
	at android.support.test.internal.a.b.run(UiThreadStatement.java:44)
	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1719)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)

Which prevented me from seeing the original failure.

BUG=736380

Review-Url: https://codereview.chromium.org/2954183002
Cr-Commit-Position: refs/heads/master@{#482004}
Committed:
https://chromium.googlesource.com/chromium/src/+/27a522ddf6ece1cccf741e309e03...
==========

[commit-bot: I haz the power, 2017-06-23 20:22:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27a522ddf6ece1cccf741e309e03...