Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2953993002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time Update tests to use ca… (Closed)

Created:
3 years, 6 months ago by panicker
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time Update tests to use capturePixelsAsyncThen to generate a frame, and check buffered values. BUG=657825, 657826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2932593002 Cr-Original-Commit-Position: refs/heads/master@{#479303} Review-Url: https://codereview.chromium.org/2953993002 . Cr-Commit-Position: refs/branch-heads/3112@{#446} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/683525a926a264914943c0100692052aa5ff7e32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -231 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/basetest.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-bg-image.html View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html View 1 chunk +17 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html View 1 chunk +15 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-paint.html View 1 chunk +33 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html View 1 chunk +16 lines, -31 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-bg-color.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-paint-only.html View 1 chunk +16 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/no-paint.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/observable.html View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
panicker
3 years, 6 months ago (2017-06-22 23:55:22 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
683525a926a264914943c0100692052aa5ff7e32.

Powered by Google App Engine
This is Rietveld 408576698