Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2953973002: [CrOS Tether] Remove notifications when they have been tapped. (Closed)

Created:
3 years, 6 months ago by Kyle Horimoto
Modified:
3 years, 6 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, net-reviews_chromium.org, Jeremy Klein, Ryan Hansberry, lesliewatkins, jmann, James Hawkins
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Remove notifications when they have been tapped. Previously, the notifications stayed around after they were tapped; this made it possible to interact with them later at a time when they may be stale. BUG=672263, 730247 Review-Url: https://codereview.chromium.org/2953973002 Cr-Commit-Position: refs/heads/master@{#481756} Committed: https://chromium.googlesource.com/chromium/src/+/8c84bfe3673e65b0a912f0bff2f726073caface5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/chromeos/net/tether_notification_presenter.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/net/tether_notification_presenter_unittest.cc View 6 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Kyle Horimoto
3 years, 6 months ago (2017-06-22 22:56:11 UTC) #2
stevenjb
lgtm
3 years, 6 months ago (2017-06-23 00:10:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953973002/1
3 years, 6 months ago (2017-06-23 00:13:41 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 01:03:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c84bfe3673e65b0a912f0bff2f7...

Powered by Google App Engine
This is Rietveld 408576698