Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2953963002:
Update Superfish interstitial strings (Closed)
DescriptionUpdate Superfish interstitial strings
This adds clean-up instructions to the Superfish interstitial. Strings might
get simplified still but this will give us something to start with.
There's also a help center URL that needs to be subbed out for a short link when
we have one ready.
BUG=734590
Review-Url: https://codereview.chromium.org/2953963002
Cr-Commit-Position: refs/heads/master@{#482146}
Committed: https://chromium.googlesource.com/chromium/src/+/4d972ec95d82f6a371eec0efad85815ae600489f
Patch Set 1 #
Total comments: 2
Patch Set 2 : rebase #Patch Set 3 : add ph tags to strings #
Total comments: 4
Patch Set 4 : update strings, meacer comments #Messages
Total messages: 22 (15 generated)
Description was changed from ========== Update Superfish interstitial strings This adds uninstall instructions to the Superfish interstitial. Strings might get simplified still but this will give us something to start with. There's also a help center URL that needs to be subbed out for a short link when we have one ready. BUG=734590 ========== to ========== Update Superfish interstitial strings This adds uninstall instructions to the Superfish interstitial. Strings might get simplified still but this will give us something to start with. There's also a help center URL that needs to be subbed out for a short link when we have one ready. Screenshot at https://drive.google.com/file/d/0B-v7-yE5qU2sS0VTM1BCVzZnNDQ/view?usp=sharing BUG=734590 ==========
estark@chromium.org changed reviewers: + meacer@chromium.org
meacer: this subs in the strings and styling for the Superfish interstitial (see screenshot in CL description). Feel free to hold off on reviewing until you're happy with the previous CL. Thanks!
https://codereview.chromium.org/2953963002/diff/1/components/security_interst... File components/security_interstitials_strings.grdp (right): https://codereview.chromium.org/2953963002/diff/1/components/security_interst... components/security_interstitials_strings.grdp:71: <li> Click <strong>Start</strong>, then search for <strong>"Uninstall a program"</strong> and double-click it</li> Do we need <ph name="BEGIN_BOLD"> and </ph> tags for these? That's what line 60 is doing, and I think it'll be difficult for translators if we leave out those tags?
The CQ bit was checked by estark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by estark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2953963002/diff/1/components/security_interst... File components/security_interstitials_strings.grdp (right): https://codereview.chromium.org/2953963002/diff/1/components/security_interst... components/security_interstitials_strings.grdp:71: <li> Click <strong>Start</strong>, then search for <strong>"Uninstall a program"</strong> and double-click it</li> On 2017/06/22 22:42:40, meacer wrote: > Do we need <ph name="BEGIN_BOLD"> and </ph> tags for these? That's what line 60 > is doing, and I think it'll be difficult for translators if we leave out those > tags? Ohh good call, done. Too bad there's not a more readable way to include strings like this :(
LGTM https://codereview.chromium.org/2953963002/diff/40001/components/security_int... File components/security_interstitials_strings.grdp (right): https://codereview.chromium.org/2953963002/diff/40001/components/security_int... components/security_interstitials_strings.grdp:72: <ph name="LIST_ITEM"><li></ph>Right-click <ph name="BEGIN_BOLD"><strong></ph>Superfish > Uninstall<ph name="END_BOLD"></strong></ph> Very minor nit: Perhaps we can use one of the unicode arrows instead of > character. But as long as the parser isn't confused, I don't think it's necessary. https://codereview.chromium.org/2953963002/diff/40001/components/security_int... components/security_interstitials_strings.grdp:73: <ph name="LIST_ITEM"><li></ph>Click <ph name="BEGIN_BOLD"><strong></ph>Start</strong>, then search for "certmgr.msc" Missing END_BOLD for the /strong tab
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update Superfish interstitial strings This adds uninstall instructions to the Superfish interstitial. Strings might get simplified still but this will give us something to start with. There's also a help center URL that needs to be subbed out for a short link when we have one ready. Screenshot at https://drive.google.com/file/d/0B-v7-yE5qU2sS0VTM1BCVzZnNDQ/view?usp=sharing BUG=734590 ========== to ========== Update Superfish interstitial strings This adds clean-up instructions to the Superfish interstitial. Strings might get simplified still but this will give us something to start with. There's also a help center URL that needs to be subbed out for a short link when we have one ready. BUG=734590 ==========
Thanks so much for the quick reviews, Mustafa. I updated the strings per email discussion, now going to land. https://codereview.chromium.org/2953963002/diff/40001/components/security_int... File components/security_interstitials_strings.grdp (right): https://codereview.chromium.org/2953963002/diff/40001/components/security_int... components/security_interstitials_strings.grdp:72: <ph name="LIST_ITEM"><li></ph>Right-click <ph name="BEGIN_BOLD"><strong></ph>Superfish > Uninstall<ph name="END_BOLD"></strong></ph> On 2017/06/23 01:20:27, meacer wrote: > Very minor nit: Perhaps we can use one of the unicode arrows instead of > > character. But as long as the parser isn't confused, I don't think it's > necessary. n/a since we changed the strings https://codereview.chromium.org/2953963002/diff/40001/components/security_int... components/security_interstitials_strings.grdp:73: <ph name="LIST_ITEM"><li></ph>Click <ph name="BEGIN_BOLD"><strong></ph>Start</strong>, then search for "certmgr.msc" On 2017/06/23 01:20:28, meacer wrote: > Missing END_BOLD for the /strong tab Done.
The CQ bit was checked by estark@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org Link to the patchset: https://codereview.chromium.org/2953963002/#ps60001 (title: "update strings, meacer comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498276806071590,
"parent_rev": "051c5b971f19b6bf84e2b8b5f2b11359263cef11", "commit_rev":
"4d972ec95d82f6a371eec0efad85815ae600489f"}
Message was sent while issue was closed.
Description was changed from ========== Update Superfish interstitial strings This adds clean-up instructions to the Superfish interstitial. Strings might get simplified still but this will give us something to start with. There's also a help center URL that needs to be subbed out for a short link when we have one ready. BUG=734590 ========== to ========== Update Superfish interstitial strings This adds clean-up instructions to the Superfish interstitial. Strings might get simplified still but this will give us something to start with. There's also a help center URL that needs to be subbed out for a short link when we have one ready. BUG=734590 Review-Url: https://codereview.chromium.org/2953963002 Cr-Commit-Position: refs/heads/master@{#482146} Committed: https://chromium.googlesource.com/chromium/src/+/4d972ec95d82f6a371eec0efad85... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/4d972ec95d82f6a371eec0efad85... |
