Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 2953933002: Fix Object method tearoffs (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/test/browser/language_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index 2896c7aab3125bd45c31303d678a205076ff3844..fc4af138944fd14f52600581d94202f810cb3e14 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -4802,7 +4802,8 @@ class CodeGenerator extends Object
result = _callHelper('bind(this, #, #)',
[safeName, _emitTargetAccess(jsTarget, name, accessor)]);
} else if (_isObjectMemberCall(target, memberName)) {
- result = _callHelper('bind(#, #, #.#)',
+ result = _callHelper(
Jennifer Messerly 2017/06/22 22:13:03 since we have just 4 of these (see `isObjectMember
vsm 2017/06/22 23:01:01 I don't think tearing these off is that common. W
+ 'bind(#, #, function (...args) { return #.#.apply(null, [this].concat(args)); })',
[jsTarget, _propertyName(memberName), _runtimeModule, memberName]);
} else {
result = _callHelper('bind(#, #)', [jsTarget, safeName]);
« no previous file with comments | « no previous file | pkg/dev_compiler/test/browser/language_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698