Fix Object method tearoffs

pkg/dev_compiler/lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 import 'dart:math' show min, max;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 4784 matching lines @@
       // which is symbolized for native classes.
       var safeName = _emitMemberName(memberName,
           type: getStaticType(target),
           isStatic: isStatic,
           element: accessor,
           alwaysSymbolizeNative: true);
       if (isSuper) {
         result = _callHelper('bind(this, #, #)',
             [safeName, _emitTargetAccess(jsTarget, name, accessor)]);
       } else if (_isObjectMemberCall(target, memberName)) {
-        result = _callHelper('bind(#, #, #.#)',
+        result = _callHelper(

[Jennifer Messerly, 2017/06/22 22:13:03]

since we have just 4 of these (see `isObjectMember`), we could avoid the rest
args/concat/apply?

        var fn = js.call(
            memberName == 'noSuchMethod'
                ? 'function(i) { return #.#(this, i); }'
                : 'function() { return #.#(this); }',
            [_runtimeModule, memberName]);
        result = _callHelper(
            'bind(#, #, #)', [jsTarget, _propertyName(memberName), fn]);

... an idea.

Another idea is we could have a custom bind method for Object method tearoffs,
but IDK if it's worth it.

[vsm, 2017/06/22 23:01:01]

I don't think tearing these off is that common.  Went with your suggested code.

+            'bind(#, #, function (...args) { return #.#.apply(null, [this].concat(args)); })',
             [jsTarget, _propertyName(memberName), _runtimeModule, memberName]);
       } else {
         result = _callHelper('bind(#, #)', [jsTarget, safeName]);
       }
     } else if (_isObjectMemberCall(target, memberName)) {
       result = _callHelper('#(#)', [memberName, jsTarget]);
     } else {
       result = _emitTargetAccess(jsTarget, name, accessor);
     }
     if (typeArgs == null) {
@@ skipping 1020 matching lines @@
   if (targetIdentifier.staticElement is! PrefixElement) return false;
   var prefix = targetIdentifier.staticElement as PrefixElement;
 
   // The library the prefix is referring to must come from a deferred import.
   var containingLibrary = resolutionMap
       .elementDeclaredByCompilationUnit(target.root as CompilationUnit)
       .library;
   var imports = containingLibrary.getImportsWithPrefix(prefix);
   return imports.length == 1 && imports[0].isDeferred;
 }