Fix Object method tearoffs

Fix Object method tearoffs

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/daf960d5a4b1d3c2817577a65a35847cf6a59e10

[vsm, 2017-06-22 21:14:04]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2017-06-22 22:13:03]

lgtm

https://codereview.chromium.org/2953933002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2953933002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:4805: result =
_callHelper(
since we have just 4 of these (see `isObjectMember`), we could avoid the rest
args/concat/apply?

        var fn = js.call(
            memberName == 'noSuchMethod'
                ? 'function(i) { return #.#(this, i); }'
                : 'function() { return #.#(this); }',
            [_runtimeModule, memberName]);
        result = _callHelper(
            'bind(#, #, #)', [jsTarget, _propertyName(memberName), fn]);

... an idea.

Another idea is we could have a custom bind method for Object method tearoffs,
but IDK if it's worth it.

[vsm, 2017-06-22 22:59:52]

Description was changed from

==========
Fix Object method tearoffs
==========

to

==========
Fix Object method tearoffs

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/daf960d5a4b1d3c2817577a65a35847cf6a59e10
==========

[vsm, 2017-06-22 22:59:54]

Committed patchset #2 (id:20001) manually as
daf960d5a4b1d3c2817577a65a35847cf6a59e10 (presubmit successful).

[vsm, 2017-06-22 23:01:01]

https://codereview.chromium.org/2953933002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2953933002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:4805: result =
_callHelper(
On 2017/06/22 22:13:03, Jennifer Messerly wrote:
> since we have just 4 of these (see `isObjectMember`), we could avoid the rest
> args/concat/apply?
> 
>         var fn = js.call(
>             memberName == 'noSuchMethod'
>                 ? 'function(i) { return #.#(this, i); }'
>                 : 'function() { return #.#(this); }',
>             [_runtimeModule, memberName]);
>         result = _callHelper(
>             'bind(#, #, #)', [jsTarget, _propertyName(memberName), fn]);
> 
> ... an idea.
> 
> Another idea is we could have a custom bind method for Object method tearoffs,
> but IDK if it's worth it.

I don't think tearing these off is that common.  Went with your suggested code.