Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2953913002: [builtins] Don't adapt arguments for Object.create. (Closed)

Created:
3 years, 6 months ago by Benedikt Meurer
Modified:
3 years, 6 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Don't adapt arguments for Object.create. Object.create is most often called with a single parameter, the prototype, and the properties are usually omitted. So optimizing for the common case, we remove the argument adaption. R=jgruber@chromium.org BUG=v8:5989 Review-Url: https://codereview.chromium.org/2953913002 Cr-Commit-Position: refs/heads/master@{#46153} Committed: https://chromium.googlesource.com/v8/v8/+/d968ed29047af017e951357fd1e60de763b4cac0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-object-gen.cc View 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 6 months ago (2017-06-22 21:09:04 UTC) #1
jgruber
lgtm
3 years, 6 months ago (2017-06-23 06:05:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953913002/1
3 years, 6 months ago (2017-06-23 06:12:00 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 06:13:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d968ed29047af017e951357fd1e60de763b...

Powered by Google App Engine
This is Rietveld 408576698