Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2953753002: Revert "Inline instance object hash code into object header on 64 bit." (Closed)

Created:
3 years, 6 months ago by erikcorry
Modified:
3 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Inline instance object hash code into object header on 64 bit." This reverts commit ac6310d5f30af5a338207a9948565096ac47c4a5 because of test failures on real ARM64 hardware as opposed to the DartVM simulator. Original review: https://codereview.chromium.org/2912863006/ R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/847cd093ba94142078565c32ce3effebe487569e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -500 lines) Patch
M runtime/lib/object.cc View 1 chunk +1 line, -9 lines 0 comments Download
M runtime/lib/object_patch.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 2 chunks +6 lines, -9 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.h View 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 3 chunks +2 lines, -43 lines 0 comments Download
M runtime/vm/become.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/become.cc View 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/freelist.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/freelist.cc View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/heap.h View 3 chunks +1 line, -10 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 3 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +1 line, -14 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 13 chunks +24 lines, -93 lines 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 17 chunks +31 lines, -56 lines 0 comments Download
M runtime/vm/raw_object.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 3 chunks +9 lines, -39 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 5 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 7 chunks +4 lines, -26 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 6 months ago (2017-06-22 08:20:32 UTC) #1
kustermann
lgtm
3 years, 6 months ago (2017-06-22 08:20:52 UTC) #2
erikcorry
3 years, 6 months ago (2017-06-22 08:22:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
847cd093ba94142078565c32ce3effebe487569e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698