Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service

pkg/front_end/test/fasta/testing/suite.dart

Index: pkg/front_end/test/fasta/testing/suite.dart
diff --git a/pkg/front_end/test/fasta/testing/suite.dart b/pkg/front_end/test/fasta/testing/suite.dart
index ed6c64dc864660be9d018792e5d60b3cbbe53569..37acdba90a8109556f30caa3d5c75fe25581a0f3 100644
--- a/pkg/front_end/test/fasta/testing/suite.dart
+++ b/pkg/front_end/test/fasta/testing/suite.dart
@@ -98,7 +98,7 @@ class FastaContext extends ChainContext {
   Uri sdk;
   Uri platformUri;
   Uri outlineUri;
-  List<int> outlineBytes;
+  Program outline;
 
   final ExpectationSet expectationSet =
       new ExpectationSet.fromJsonList(JSON.decode(EXPECTATIONS));
@@ -139,15 +139,12 @@ class FastaContext extends ChainContext {
   }
 
   Future<Program> loadPlatformOutline() async {
-    if (outlineBytes == null) {
+    if (outline == null) {

[ahe, 2017/07/06 13:12:22]

This is rather brittle. There's a potential for race conditions here.

[Siggi Cherem (dart-lang), 2017/07/06 19:05:28]

Is the change making it worse, or are you saying this was brittle from before as
well?

I recall we made the change in https://codereview.chromium.org/2914773003 to
ensure we didn't have a race condition before we invoke the `run` step. If
that's not enough, we could move this and load the outline upfront in
`FastaContext.create`

       await ensurePlatformUris();
-      outlineBytes = new File.fromUri(outlineUri).readAsBytesSync();
+      outline =
+          loadProgramFromBytes(new File.fromUri(outlineUri).readAsBytesSync());
     }
-    // Note: we rebuild the platform outline on every test because the compiler
-    // currently mutates the in-memory representation of the program without
-    // cloning it.
-    // TODO(sigmund): investigate alternatives to this approach.
-    return loadProgramFromBytes(outlineBytes);
+    return outline;
   }
 
   static Future<FastaContext> create(
@@ -259,7 +256,7 @@ class Outline extends Step<TestDescription, Program, FastaContext> {
       }
       p = await sourceTarget.buildOutlines();
       if (fullCompile) {
-        p = await sourceTarget.buildProgram(trimDependencies: true);
+        p = await sourceTarget.buildProgram();
         instrumentation?.finish();
         if (instrumentation != null && instrumentation.hasProblems) {
           if (updateComments) {